Bug 255906 - sysutils/lsblk: update to 3.5
Summary: sysutils/lsblk: update to 3.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Lewis Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-15 16:18 UTC by vermaden
Modified: 2021-05-15 17:24 UTC (History)
1 user (show)

See Also:


Attachments
lsblk-3.5.diff (990 bytes, patch)
2021-05-15 16:18 UTC, vermaden
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description vermaden 2021-05-15 16:18:14 UTC
Created attachment 224973 [details]
lsblk-3.5.diff

Hi,

I would like to update the 'lsblk' port again.

I have found some new - quite important bugs and fixed them.

I attached the diff(1) output.

If something more is needed then let me know.

Thank you.

Regards.
Comment 1 vermaden 2021-05-15 16:19:14 UTC
Chengelog if needed.

- Remove control sequences and colors from output when listing disks.
- Use diskinfo(8) only for md(4) disks as geom(4) does not support them.
- Add new comments and rework some of the older ones.
- Add additional checks for SIZE gathering and printing.
- Properly print exFAT filesystem label when on entire device without partitions.
- Fix display of NTFS-3G mountpoints.
- Check automount(8) /var/run/automount.state for fusefs(5) filesystems.
Comment 2 commit-hook freebsd_committer 2021-05-15 17:15:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3625ba51feb356d0e2e1948ea99d2090582867bb

commit 3625ba51feb356d0e2e1948ea99d2090582867bb
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2021-05-15 17:09:48 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-05-15 17:13:46 +0000

    sysutils/lsblk: Update to 3.5

    * Remove control sequences and colors from output when listing disks.
    * Use diskinfo(8) only for md(4) disks as geom(4) does not support them.
    * Add new comments and rework some of the older ones.
    * Add additional checks for SIZE gathering and printing.
    * Properly print exFAT filesystem label when on entire device without partitions.
    * Fix display of NTFS-3G mountpoints.
    * Check automount(8) /var/run/automount.state for fusefs(5) filesystems.

    PR:             255906
    Submitted by:   vermaden@interia.pl (maintainer)

 sysutils/lsblk/Makefile | 4 ++--
 sysutils/lsblk/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2021-05-15 17:16:20 UTC
Committed, thanks!
Comment 4 vermaden 2021-05-15 17:18:07 UTC
Thank You for help.

Regards.
Comment 5 Lewis Cook freebsd_committer freebsd_triage 2021-05-15 17:24:38 UTC
(In reply to vermaden from comment #4)
Always welcome!

One little nit that I forgot to mention, when submitting an update of a port you are the maintainer of, is to set the maintainer-approval attachment flag (to +) on the patch.  Otherwise everything else looks fine. :)

Cheers!