Bug 255916 - [New port] dns/hetzner_ddns: Hetzner Dynamic DNS daemon
Summary: [New port] dns/hetzner_ddns: Hetzner Dynamic DNS daemon
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/filiparag/hetzner_...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-16 02:33 UTC by Filip Parag
Modified: 2021-06-09 14:14 UTC (History)
2 users (show)

See Also:


Attachments
hetzner_ddns v0.1 (1.78 KB, patch)
2021-05-16 02:33 UTC, Filip Parag
filip: maintainer-approval+
Details | Diff
hetzner_ddns v0.2 (1.89 KB, patch)
2021-05-16 23:14 UTC, Filip Parag
filip: maintainer-approval+
Details | Diff
hetzner_ddns-0.2.2 (2.17 KB, patch)
2021-06-08 22:27 UTC, Filip Parag
filip: maintainer-approval+
Details | Diff
proposed_changes (720 bytes, patch)
2021-06-09 11:13 UTC, Filip Parag
filip: maintainer-approval+
Details | Diff
hetzner_ddns-0.2.2u1 (2.69 KB, patch)
2021-06-09 14:14 UTC, Filip Parag
filip: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Parag 2021-05-16 02:33:11 UTC
Created attachment 224984 [details]
hetzner_ddns v0.1

I decided to share my DynDNS script for all users who rely on Hetzner DNS servers. This port is inspired by dns/namesilo_ddns.

Tested on FreeBSD 13.0 arm64
Portlint ok
Comment 1 Filip Parag 2021-05-16 23:14:40 UTC
Created attachment 225010 [details]
hetzner_ddns v0.2

Update port to version 0.2.0
Comment 2 Filip Parag 2021-06-08 22:27:32 UTC
Created attachment 225651 [details]
hetzner_ddns-0.2.2

Update port to version 0.2.2
Comment 3 Daniel Engberg 2021-06-09 08:05:56 UTC
L2 should be removed (and L1 can also be removed)
PORTVERSION --> DISTVERSION
https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-master_sites-github-description

USE_RC_SUBR seems to be missing?
https://docs.freebsd.org/en/books/porters-handbook/book.html#rc-scripts

Thanks for your contribution!

Best regards,
Daniel
Comment 4 Filip Parag 2021-06-09 11:13:36 UTC
Created attachment 225658 [details]
proposed_changes

(In reply to Daniel Engberg from comment #3)
Hello Daniel,

Thanks for your suggestions. I had some issues trying to implement them.

When I remove line L2, portlint says:
> FATAL: Makefile: no $FreeBSD$ line in comment section.
Removing both L1 and L2 gives even more errors.

Regarding the use of USE_RC_SUBR, I encounter a problem which I don't know how to fix. I scoured the Handbook, but I can't find how resolve the following:

The rc.d script for FreeBSD is named hetzner_ddns.freebsd.rc and it lies in ${WRKSRC} directory alongside the rest of the upstream code.
I copy it to ${FILESDIR}/${PORTNAME}.in in the do-patch target, but even though it runs before configuration step, I get an error:
> ** Missing /usr/ports/dns/hetzner_ddns/files/hetzner_ddns.in for hetzner_ddns-0.2.2.
Using post-extract target yields the same result, but running make package the second time resolves this issue.

I would like to keep the rc.d script upstream only, without a duplicate in port's files/ directory. Is it possible to do so?

Proposed changes are attached in proposed_changes file.

Best,
Filip
Comment 5 Daniel Engberg 2021-06-09 13:14:25 UTC
Portlint needs a bit of love in that regard (updating).
Regarding your rc.d-script I don't see a nice/viable solution except for hosting it in the ports tree, having a port modifying the ports tree is a no go.
Comment 6 Filip Parag 2021-06-09 14:14:23 UTC
Created attachment 225661 [details]
hetzner_ddns-0.2.2u1

Applied suggestions from comment #3.

Tested on FreeBSD 13.0 arm64