Bug 255922 - sysutils/xosview: PATCH to compile on aarch64 and other archs
Summary: sysutils/xosview: PATCH to compile on aarch64 and other archs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-16 13:56 UTC by Otacílio de Araújo Ramos Neto
Modified: 2021-05-24 00:48 UTC (History)
2 users (show)

See Also:
otaciliodearaujo: maintainer-feedback+


Attachments
Patch to port (2.25 KB, patch)
2021-05-16 13:56 UTC, Otacílio de Araújo Ramos Neto
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Otacílio de Araújo Ramos Neto 2021-05-16 13:56:57 UTC
Created attachment 224993 [details]
Patch to port

xosview uses APM api to get info from battery. This blocks the compilation under architectures other than amd64 and i386. This patch adds a conditional compilation that enables the compile and run of xosview under others archs than amd64 and i386. Tested under aarch64.
Comment 1 Otacílio de Araújo Ramos Neto 2021-05-16 14:57:39 UTC
I approve this patch
Comment 2 Li-Wen Hsu freebsd_committer 2021-05-17 16:54:19 UTC
(In reply to otacilio.neto from comment #0)
Thanks for the patch, can you setup your name (at https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account ) then we can use it in the author field in the git log?
Comment 3 Otacílio de Araújo Ramos Neto 2021-05-18 10:51:55 UTC
(In reply to Li-Wen Hsu from comment #2)
Ok. Name updated.
Comment 4 commit-hook freebsd_committer 2021-05-24 00:48:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb4bd742805ad510aa813c322045875e72f05eac

commit fb4bd742805ad510aa813c322045875e72f05eac
Author:     Otacílio de Araújo Ramos Neto <otacilio.neto@bsd.com.br>
AuthorDate: 2021-05-24 00:46:29 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-05-24 00:46:29 +0000

    sysutils/xosview: Fix build for aarch64 and other archs

    PR:             255922

 sysutils/xosview/Makefile                        |  4 +-
 sysutils/xosview/files/patch-bsd_kernel.cc (new) | 50 ++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 3 deletions(-)