Bug 255946 - security/openvpn: delete .orig files
Summary: security/openvpn: delete .orig files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-17 15:09 UTC by Mikael Urankar
Modified: 2021-06-03 12:35 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+

Attachments
v0 (469 bytes, patch)
2021-05-17 15:09 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2021-05-17 15:09:43 UTC 
Created attachment 225030 [details]
v0

leftovers from some paches

find work/stage/ -name "*.orig"                                                                                                                                         
work/stage/usr/local/share/examples/openvpn/sample-config-files/loopback-client.orig                                                                                                                              
work/stage/usr/local/share/examples/openvpn/sample-config-files/loopback-server.orig
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2021-05-17 17:30:09 UTC 
Thanks for the report, Mikael.  
Bug is confirmed, patch looks good, testing on builders.
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2021-05-17 17:46:11 UTC 
Turns out I needed to remove an excess openvpn/ component from the patch#s path on the ${RM} line (note ${RM} implies rm -f so you don't get errors if you miss the file through wrong paths.)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-05-17 18:01:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=42101271373865d49753e8d7b1fb66dfce325dd0

commit 42101271373865d49753e8d7b1fb66dfce325dd0
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-05-17 17:51:03 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-05-17 17:56:12 +0000

    security/openvpn: do not package .orig leftovers from patch

    Bump PORTREVISION as we change the pkg-plist.
    (Includes -mbedtls port variant.)

    PR:             255946
    Based on a patch by and
    Reported by:    Mikael Urankar (mikael@)

 security/openvpn/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-06-03 12:35:58 UTC 
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d05f5c1513c0e253ebbd2cfa326d3aaaada92f1

commit 8d05f5c1513c0e253ebbd2cfa326d3aaaada92f1
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-05-17 17:51:03 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-06-03 12:34:54 +0000

    security/openvpn: do not package .orig leftovers from patch

    Bump PORTREVISION as we change the pkg-plist.
    (Includes -mbedtls port variant.)

    PR:             255946
    Based on a patch by and
    Reported by:    Mikael Urankar (mikael@)

    (cherry picked from commit 42101271373865d49753e8d7b1fb66dfce325dd0)

 security/openvpn/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)