Bug 256042 - net-im/matterircd: Fix wrong statup options in rc file
Summary: net-im/matterircd: Fix wrong statup options in rc file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-20 22:02 UTC by Julien Dessaux
Modified: 2022-12-02 14:48 UTC (History)
2 users (show)

See Also:
norrland: maintainer-feedback+


Attachments
proposed patch (662 bytes, patch)
2021-05-20 22:02 UTC, Julien Dessaux
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Dessaux 2021-05-20 22:02:52 UTC
Created attachment 225137 [details]
proposed patch

Hi,

The options in the rc file are invalid therefore a fresh installation of matterircd cannot start. It will fail with a daemon log that looks like :
May 20 22:48:41 matterircd matterircd[40090]: unknown shorthand flag: 'c' in -conf=/usr/local/etc/matterircd.toml
May 20 22:48:41 matterircd matterircd[40090]: Usage of /usr/local/bin/matterircd:
May 20 22:48:41 matterircd matterircd[40090]:       --bind string      interface:port to bind to, or a path to bind to a Unix socket. (default "127.0.0.1:6667")
May 20 22:48:41 matterircd matterircd[40090]:       --conf string      config file (default "matterircd.toml")
May 20 22:48:41 matterircd matterircd[40090]:       --debug            enable debug logging
May 20 22:48:41 matterircd matterircd[40090]:       --tlsbind string   interface:port to bind to. (e.g 127.0.0.1:6697)
May 20 22:48:41 matterircd matterircd[40090]:       --tlsdir string    directory to look for key.pem and cert.pem. (default ".")
May 20 22:48:41 matterircd matterircd[40090]:       --version          show version

Adding a second dash to change -conf= into --conf= fixes the issue.

Patch is attached.
Comment 1 norrland 2021-05-21 09:52:51 UTC
Looks good, thanks for catching this.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-12-02 07:06:15 UTC
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-02 07:06:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d84430390ffc225f3969d2fe3cd76ad3ad26dd4c

commit d84430390ffc225f3969d2fe3cd76ad3ad26dd4c
Author:     Julien Dessaux <julien.dessaux@adyxax.org>
AuthorDate: 2022-12-01 16:11:04 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-12-02 07:01:57 +0000

    net-im/matterircd: Fix wrong statup options in rc file

    PR:             256042
    Reported by:    julien.dessaux@adyxax.org
    Approved by:    norrland@nullbyte.se (maintainer)

 net-im/matterircd/files/matterircd.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Julien Dessaux 2022-12-02 14:48:50 UTC
Thank you Fernando!