Bug 256104 - editors/linux-sublime3: Add missing LICENSE file
Summary: editors/linux-sublime3: Add missing LICENSE file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Lewis Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-23 17:35 UTC by Matías Pizarro
Modified: 2021-05-23 20:44 UTC (History)
1 user (show)

See Also:


Attachments
Adds missing files/LICENSE.txt (3.03 KB, patch)
2021-05-23 17:35 UTC, Matías Pizarro
matias: maintainer-approval+
Details | Diff
Adds license file and reformats Makefile (4.94 KB, patch)
2021-05-23 20:14 UTC, Matías Pizarro
matias: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matías Pizarro 2021-05-23 17:35:10 UTC
Created attachment 225201 [details]
Adds missing files/LICENSE.txt

I submitted a patch created with `diff -u` instead of `diff -ruN` and broke the port
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256090

The attached patch:
 * adds missing file (files/LICENSE.txt)
 * bumps PORTREVISION up from 1 to 2

Lesson learned
Comment 1 Matías Pizarro 2021-05-23 17:37:52 UTC
passes QA
  - portlint: OK (looks fine.)
  - testport: OK (poudriere: 130amd64, 130i386)
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2021-05-23 18:49:19 UTC
Moin moin, only a few nits.

When installing the icons within the do-install target, I suggest using a for loop to help reduce boilerplate, so something like;

.for res in 16 32 48 128 256
        @${MKDIR} ${STAGEDIR}${DATADIR} \
                ${STAGEDIR}${PREFIX}/share/icons/hicolor/${res}x${res}/apps/
        ${INSTALL_DATA} ${WRKSRC}/Icon/${res}x${res}/sublime-text.png \
                ${STAGEDIR}${PREFIX}/share/icons/hicolor/${res}x${res}/apps/
.endfor

I am getting a few complaints with portclippy[1] about the order of some variables if you want to address those. Lastly, to keep port Makefiles consistently formatted, it's recommended to use portfmt which is also included in [1]. Otherwise, it looks okay to me. Cheers!

[1] Part of the suite in https://www.freshports.org/ports-mgmt/portfmt/
Comment 3 Matías Pizarro 2021-05-23 20:14:51 UTC
Created attachment 225207 [details]
Adds license file and reformats Makefile
Comment 4 commit-hook freebsd_committer 2021-05-23 20:44:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=83539d8247cbd8cff831f374acb59331a1123f48

commit 83539d8247cbd8cff831f374acb59331a1123f48
Author:     Matías Pizarro <matias@pizarro.net>
AuthorDate: 2021-05-23 20:39:38 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-05-23 20:41:05 +0000

    editors/linux-sublime3: Add missing LICENSE file

    While here, pet portclippy and portfmt.

    PR:     256104

 editors/linux-sublime3/Makefile                | 33 +++++++++++---------------
 editors/linux-sublime3/files/LICENSE.txt (new) | 21 ++++++++++++++++
 2 files changed, 35 insertions(+), 19 deletions(-)
Comment 5 Lewis Cook freebsd_committer freebsd_triage 2021-05-23 20:44:55 UTC
Committed, thanks!