Bug 256167 - databases/postgresql13-server: Fix build with clang 12
Summary: databases/postgresql13-server: Fix build with clang 12
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: pgsql
URL:
Keywords:
Depends on:
Blocks: 255570
  Show dependency treegraph
 
Reported: 2021-05-26 11:43 UTC by Dimitry Andric
Modified: 2021-10-19 15:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (pgsql)


Attachments
Bump highest LLVM version in ports to 12 (585 bytes, patch)
2021-05-26 11:43 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2021-05-26 11:43:01 UTC
Created attachment 225276 [details]
Bump highest LLVM version in ports to 12

During an exp-run for llvm 12 (see bug 255570), it turned out that cad/brlcad does not build with clang 12.0.0 [1], at least not on i386:

...
cd '/wrkdirs/usr/ports/databases/postgresql13-server/work/stage/usr/local/lib/postgresql/bitcode' && /usr/local/llvm11/bin/llvm-lto -thinlto -thinlto-action=thinlink -o postgres.index.bc postgres/access/brin/brin.bc postgres/access/brin/brin_inclusion.bc postgres/access/brin/brin_minmax.bc postgres/access/brin/brin_pageops.bc [...lots more bc files...]
LLVM ERROR: ThinLTO cannot create input file: Unknown attribute kind (97) (Producer: 'LLVM12.0.0' Reader: 'LLVM 11.0.1')
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.

Obviously this is a mixup between .bc files compiled with clang 12, and the /usr/local/llvm11/bin/llvm-lto which is 11.0.1.

It seems that the "Highest LLVM version in ports" mentioned in databases/postgresql13-server/Makefile is still at 11, so can we bump that to 12? Then this problem should go away.

[1] http://gohan04.nyi.freebsd.org/data/maini386PR255570-default/2021-05-23_20h12m16s/logs/errors/postgresql13-server-13.3.log
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2021-05-26 11:45:44 UTC
Eh in the description, please substitute cad/brlcad with databases/postgresql13-server. :)  Note that the exp-run showed similar failures for the other databases/postgreslXX-server ports, but these are all handled similarly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-12 16:24:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a271b9d5b7b2c0eb57d1a09fc44f2ecbbad7bc5a

commit a271b9d5b7b2c0eb57d1a09fc44f2ecbbad7bc5a
Author:     Palle Girgensohn <girgen@FreeBSD.org>
AuthorDate: 2021-08-12 15:48:09 +0000
Commit:     Palle Girgensohn <girgen@FreeBSD.org>
CommitDate: 2021-08-12 16:23:00 +0000

    databases/postgresql*: update to latest versions

    The PostgreSQL Global Development Group has released an update to all supported
    versions of our database system, including 13.4, 12.8, 11.13, 10.18, and
    9.6.23, as well as the third beta release of PostgreSQL 14. This release closes
    one security vulnerability and fixes over 75 bugs reported over the last three
    months.

    Turn off parallel builds since we continue to struggle with build problems when
    it is activated. [1]

    Avoid chasing latest LLVM version. [2]

    PR:             256466 [1], 256167 [2]
    Release notes:  https://www.postgresql.org/docs/release/
    Security:       b471130b-fb86-11eb-87db-6cc21735f730

 databases/postgresql10-server/Makefile             |   4 +-
 databases/postgresql10-server/distinfo             |   6 +-
 .../postgresql10-server/files/patch-icu68 (gone)   | 254 ---------------------
 databases/postgresql11-server/Makefile             |   4 +-
 databases/postgresql11-server/distinfo             |   6 +-
 databases/postgresql12-docs/Makefile               |  44 +---
 databases/postgresql12-server/Makefile             |   4 +-
 databases/postgresql12-server/distinfo             |   6 +-
 databases/postgresql13-docs/Makefile               |  44 +---
 databases/postgresql13-server/Makefile             |   4 +-
 databases/postgresql13-server/distinfo             |   6 +-
 databases/postgresql14-docs/Makefile               |   4 +-
 databases/postgresql14-server/Makefile             |  10 +-
 databases/postgresql14-server/distinfo             |   6 +-
 databases/postgresql14-server/pkg-plist-client     |   2 +-
 databases/postgresql14-server/pkg-plist-server     |   4 +-
 databases/postgresql96-server/Makefile             |   4 +-
 databases/postgresql96-server/distinfo             |   6 +-
 18 files changed, 42 insertions(+), 376 deletions(-)