Bug 256170 - Mk/Uses/scons.mk: remove support for python2
Summary: Mk/Uses/scons.mk: remove support for python2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://reviews.freebsd.org/D30472
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-26 15:13 UTC by Dmitry Marakasov
Modified: 2021-05-26 20:35 UTC (History)
1 user (show)

See Also:


Attachments
Patch (956 bytes, patch)
2021-05-26 15:13 UTC, Dmitry Marakasov
no flags Details | Diff
Patch (1.24 KB, patch)
2021-05-26 16:16 UTC, Dmitry Marakasov
no flags Details | Diff
Patch (1.28 KB, patch)
2021-05-26 16:20 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2021-05-26 15:13:34 UTC
Created attachment 225278 [details]
Patch

Since no cases of scons:python2 are left in the ports, we can remove support for args and python2.
Comment 1 Dmitry Marakasov freebsd_committer 2021-05-26 16:16:04 UTC
Created attachment 225281 [details]
Patch

Update patch, add check for absence of args.
Comment 2 Dmitry Marakasov freebsd_committer 2021-05-26 16:20:30 UTC
Created attachment 225283 [details]
Patch
Comment 3 commit-hook freebsd_committer 2021-05-26 19:04:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd9b99277f42573d15ed4fd4eb9b83b62bc1cb0c

commit bd9b99277f42573d15ed4fd4eb9b83b62bc1cb0c
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2021-05-26 18:56:29 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2021-05-26 19:00:22 +0000

    Mk/Uses/scons.mk: Clean up after the removal of all scons:python2 usage

    PR:             256170
    Differential Revision:  https://reviews.freebsd.org/D30472

 Mk/Uses/scons.mk | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
Comment 4 Po-Chuan Hsieh freebsd_committer 2021-05-26 19:06:31 UTC
Committed. Thanks!
Comment 5 Po-Chuan Hsieh freebsd_committer 2021-05-26 20:35:11 UTC
(In reply to Dmitry Marakasov from comment #0)

Thank you for fixing all python2 cases. Now we could prepare scons 4 update.

(In reply to commit-hook from comment #3)

The review is also approved by rene@.