Bug 256181 - net/py-speedtest-cli: 2.1.3 needs to be MFH
Summary: net/py-speedtest-cli: 2.1.3 needs to be MFH
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-27 05:30 UTC by Guangyuan Yang
Modified: 2021-05-31 05:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nivit)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer freebsd_triage 2021-05-27 05:30:40 UTC 
Version 2.1.3 includes a fix that should be backported, see:

https://github.com/sivel/speedtest-cli/pull/769

Otherwise, speedtest-cli is unusable in 2.1.2 (quarterly branch).
Comment 1 Guangyuan Yang freebsd_committer freebsd_triage 2021-05-27 05:32:00 UTC 
➜  ~ speedtest --simple
Traceback (most recent call last):
  File "/usr/local/bin/speedtest", line 11, in <module>
    load_entry_point('speedtest-cli==2.1.2', 'console_scripts', 'speedtest')()
  File "/usr/local/lib/python3.7/site-packages/speedtest.py", line 1986, in main
    shell()
  File "/usr/local/lib/python3.7/site-packages/speedtest.py", line 1875, in shell
    secure=args.secure
  File "/usr/local/lib/python3.7/site-packages/speedtest.py", line 1091, in __init__
    self.get_config()
  File "/usr/local/lib/python3.7/site-packages/speedtest.py", line 1174, in get_config
    map(int, server_config['ignoreids'].split(','))
ValueError: invalid literal for int() with base r10: ''

➜  ~ uname -a
FreeBSD YGY-ThinkCentre 13.0-RELEASE FreeBSD 13.0-RELEASE #0 releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-05-31 05:33:42 UTC 
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=67b6c1736054d19c72974e203bc58ebe9ec758a2

commit 67b6c1736054d19c72974e203bc58ebe9ec758a2
Author:     Nicola Vitale <nivit@FreeBSD.org>
AuthorDate: 2021-04-12 14:50:43 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-05-31 05:28:22 +0000

    net/py-speedtest-cli: update to 2.1.3

    v2.1.3 includes a runtime fix [1], without which the port is not usable,
    hence it needs to be MFH'ed.

    [1]:            https://github.com/sivel/speedtest-cli/pull/769

    Changes:        https://github.com/sivel/speedtest-cli/releases/tag/v2.1.3

    PR:             254906, 256181
    MFH Approved by:        lwhsu (mentor), portmgr (blanket, runtime fix)

    (cherry picked from commit ee9e5cfd9328ecd7cc0aec2db0c0e8c086ade442)

 net/py-speedtest-cli/Makefile | 4 ++--
 net/py-speedtest-cli/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)