Bug 256185 - Mk/Uses: do not call bare ${ECHO} which is no-op in silent mode
Summary: Mk/Uses: do not call bare ${ECHO} which is no-op in silent mode
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-27 11:19 UTC by Franco Fichtner
Modified: 2021-06-11 08:02 UTC (History)
2 users (show)

See Also:


Attachments
fix ECHO use (478 bytes, patch)
2021-05-27 11:19 UTC, Franco Fichtner
no flags Details | Diff
replace ECHO use in framework (2.85 KB, patch)
2021-06-11 05:57 UTC, Franco Fichtner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2021-05-27 11:19:51 UTC
Created attachment 225304 [details]
fix ECHO use

ECHO is silenced by "make -s" invoke breaking gem plist generation....
Comment 1 Alexey Dokuchaev freebsd_committer 2021-05-31 02:31:07 UTC
I'd suggest fixing all cases of ${ECHO} use in Mk/* in a single commit, e.g. in Mk/Uses/apache.mk and couple of others.
Comment 2 Franco Fichtner 2021-05-31 06:27:19 UTC
I'd also suggest portmgr picking up the concern of the constant taint in ports and framework since clearly this situation is unwanted and causes all sorts of build problems for individual ports consumers.
Comment 3 Franco Fichtner 2021-06-09 07:52:20 UTC
I really don't want to impose, but it's also not great to have outside contributions sidelined like this. It's a single line commit with a clear scope and no side effects.

If I can help push this further I will...


Cheers,
Franco
Comment 4 Alexey Dokuchaev freebsd_committer 2021-06-09 08:09:21 UTC
(In reply to Franco Fichtner from comment #3)
> I really don't want to impose, but it's also not great to have outside
> contributions sidelined like this.
No one is sidelining anything.  Let's give assigned committer a few more days to handle it; if he's too busy or got sidetracked, I'll help push it forward after that.
Comment 5 Koichiro Iwao freebsd_committer 2021-06-11 05:13:19 UTC
Sorry about the hold. As Alexey said, fixing all case of ${ECHO} use in a single commit would be better. I don't have time for searching all use of that. Anyone, please do that.
Comment 6 Franco Fichtner 2021-06-11 05:57:13 UTC
Created attachment 225720 [details]
replace ECHO use in framework

Okay, I used following strategy to find stray ECHO use in the framework:

# git grep '{ECHO}' [A-Z]*

It's not so much here really. The most problems lie in the individual ports and I can propose fixes there too (maybe per category), but will you take this particular patch for the framework first?


Cheers,
Franco
Comment 7 Alexey Dokuchaev freebsd_committer 2021-06-11 07:01:34 UTC
(In reply to Franco Fichtner from comment #6)
> It's not so much here really.
You're right, it is not.  I'll take care of it.
Comment 8 commit-hook freebsd_committer 2021-06-11 07:39:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f16e30b305b5a94cae5e2568913299ced32f0492

commit f16e30b305b5a94cae5e2568913299ced32f0492
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-06-11 07:34:42 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-06-11 07:37:22 +0000

    Mk/Uses: replace bare ${ECHO} with ${ECHO_CMD} or ${ECHO_MSG}

    ECHO is builtin variable and is cleared when make(1) is invoked
    in silent mode, i.e. as ``make -s'', thus making statements that
    use it do nothing.  Depending on the context, replace it with
    either ${ECHO_CMD} or ${ECHO_MSG} (in one case), as appropriate.

    PR:             256185
    Submitted by:   Franco Fichtner

 Mk/Uses/apache.mk | 16 ++++++++--------
 Mk/Uses/gem.mk    |  2 +-
 Mk/Uses/mono.mk   |  2 +-
 Mk/Uses/perl5.mk  |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)
Comment 9 Franco Fichtner 2021-06-11 07:58:04 UTC
Thanks, shall I propose category-based patches for individual ports or should this go via another ticket/channel?

It's about 275 ports affected from a quick command line check...


Cheers,
Franco
Comment 10 Alexey Dokuchaev freebsd_committer 2021-06-11 08:02:44 UTC
(In reply to Franco Fichtner from comment #9)
> shall I propose category-based patches for individual ports?
Not sure, maybe I'll just fix those ports myself, can't decide yet.