Created attachment 225306 [details] py-django-ckeditor port files https://pypi.org/project/django-ckeditor/
^Triage: fix Summary. Note to submitter: the pkg-descr is kind of sparse. To me, it seems to assume that I already know what the package does.
do i need to provide anything else to get this in the port tree?
Review items: - Latest upstream version is 6.1.0 - Add python to CATEGORIES - Match COMMENT to upstream description (setup.py:description). "Django admin CKEditor integration" - Match upstream dependency <versions-specs> ("django-js-asset>=1.2.2",) - ",run" is incorrect for most python package cases. It excludes "build" ('run time *only*), which is required to compile py files to pyo pyc counterparts. - Upstream is only testing Python 3.6+, this port declares 3.4+ support. This isd fine if the packages tests pass with all allowed versions. - Upstream ships tests. Add TEST_DEPENDS and a test-target for comprehensive QA: Note #1: we don't need to run tox, coverage or lint tests, the following two should be sufficient: TEST_ENV+=DJANGO_SETTINGS_MODULE=ckeditor_demo.settings ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py test ckeditor_demo ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py validate_templates Note 2: There are a few more dependencies for tests (pillow, django_extensions). Only add compulsory ones. Interesting to note that these deps arent in install_requires. Are they 'optional' ? Maybe its worth having OPTIONS for these. Confirmation that the port passes tests (portlint, poudriere) would also be great.
See Also: https://wiki.freebsd.org/Python/PortsPolicy