Bug 256197 - Bad END label in arm64/bus_space_asm.S
Summary: Bad END label in arm64/bus_space_asm.S
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-27 14:20 UTC by Nick Reilly
Modified: 2021-06-07 00:46 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Reilly 2021-05-27 14:20:42 UTC 
The END() for generic_bs_fault is incorrect, it is "bus_fault" rather than "generic_bs_fault".

https://cgit.freebsd.org/src/tree/sys/arm64/arm64/bus_space_asm.S#n400

ENTRY(generic_bs_fault)
	mov	x0, #-1
	ret
END(bus_fault)
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-05-28 13:10:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d097687b315671191b16494c938d3ceecd3eca4f

commit d097687b315671191b16494c938d3ceecd3eca4f
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-05-28 00:10:26 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-05-28 13:10:11 +0000

    arm64: correct END() copy-pasteo for generic_bs_fault

    PR:             256197
    Reported by:    Nick Reilly
    MFC after:      1 week
    Fixes:          95a85c125d0e67 ("Add NetBSD compatible bus_space_peek_N()...")
    Sponsored by:   The FreeBSD Foundation

 sys/arm64/arm64/bus_space_asm.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-06-07 00:42:37 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b556a0eebf4dd3179d744acdab276f77f61da30f

commit b556a0eebf4dd3179d744acdab276f77f61da30f
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-05-28 00:10:26 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-06-07 00:41:17 +0000

    arm64: correct END() copy-pasteo for generic_bs_fault

    PR:             256197
    Reported by:    Nick Reilly
    MFC after:      1 week
    Fixes:          95a85c125d0e67 ("Add NetBSD compatible bus_space...")
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit d097687b315671191b16494c938d3ceecd3eca4f)

 sys/arm64/arm64/bus_space_asm.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)