Bug 256258 - sysutils/htop: Patch to add regex support via GNU regex library
Summary: sysutils/htop: Patch to add regex support via GNU regex library
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-30 11:29 UTC by parv
Modified: 2021-06-28 06:31 UTC (History)
3 users (show)

See Also:
gaod: maintainer-feedback+


Attachments
Patch for port Makefile & htop 3.0.4 files. (13.98 KB, patch)
2021-05-30 11:29 UTC, parv
no flags Details | Diff
Patch for port Makefile & htop 3.0.5 files. (13.89 KB, patch)
2021-06-01 08:39 UTC, parv
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description parv 2021-05-30 11:29:29 UTC
Created attachment 225369 [details]
Patch for port Makefile & htop 3.0.4 files.

The patch adds regex support to filter function of htop via GNU regex library. Main patch set -- everything but the port Makefile -- has been manually updated from an old version located at ...

  https://github.com/hishamhm/htop/pull/428

... which was never adopted by earlier maintainer(s).
Comment 1 Hung-Yi Chen 2021-06-01 04:52:21 UTC
I suggest also send a pull request to htop new upstream: https://github.com/htop-dev/htop

And, have you tried to apply it to htop 3.0.5?
Comment 2 parv 2021-06-01 05:22:55 UTC
(In reply to Hung-Yi Chen from comment #1)

No, I have not tried to apply to version 3.0.5? Is it in Ports now?
Comment 3 parv 2021-06-01 08:28:36 UTC
The I had submitted does not apply to 3.0.5 version.


I was trying to log in here, but keep getting "password invalid" message in Firefox on FreeBSD in virtual machine. I am typing this in Firefox on Windows. Now, my account is about to be locked. Excellent.


Next I will post the patch set against version 3.0.5.
Comment 4 parv 2021-06-01 08:39:27 UTC
Created attachment 225443 [details]
Patch for port Makefile & htop 3.0.5 files.

- This patch for htop 3.0.5 is independent of previous patch submitted.

- The Ports collection still had version 3.0.4. It assumes that sysutils/htop is already at 3.0.5.

- It does not updated the existing port to 3.0.5.
Comment 5 Hung-Yi Chen 2021-06-27 21:05:01 UTC
LGTM.
Comment 6 Li-Wen Hsu freebsd_committer 2021-06-28 02:16:08 UTC
(In reply to parv from comment #4)
The patch builds file and approved by the maintainer. Do you want to set your full name at https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so we can put that in `git commit --author`? Thanks!
Comment 7 parv 2021-06-28 06:31:46 UTC
(In reply to Li-Wen Hsu from comment #6)

"parv" (without quotes of course) is good for the git-author entry.