Bug 256275 - audio/moc: update to include WAVPACK
Summary: audio/moc: update to include WAVPACK
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-30 22:35 UTC by Rob Zinkov
Modified: 2021-06-01 16:26 UTC (History)
1 user (show)

See Also:


Attachments
Patch to the Makefile (450 bytes, patch)
2021-05-30 22:35 UTC, Rob Zinkov
no flags Details | Diff
Updated patch file (967 bytes, patch)
2021-06-01 16:02 UTC, Rob Zinkov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Zinkov 2021-05-30 22:35:43 UTC
Created attachment 225387 [details]
Patch to the Makefile

This includes wavpack so the audio player can support more audio formats
Comment 1 Li-Wen Hsu freebsd_committer 2021-06-01 14:51:08 UTC
Thanks for the patch. Would you mind to set your name in the bugzilla so I can put it in the author line of Git log?

https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account

Thanks!
Comment 2 Li-Wen Hsu freebsd_committer 2021-06-01 14:53:04 UTC
Hi, because this changes the default build options so bumping PORTREVISION is needed. Also, if possible, a patch generated with `git format-patch` is preferred because it is easier for committer to just apply that to the tree.
Comment 3 Rob Zinkov 2021-06-01 16:02:17 UTC
Created attachment 225463 [details]
Updated patch file
Comment 4 Rob Zinkov 2021-06-01 16:06:43 UTC
Does that work?
Comment 5 Li-Wen Hsu freebsd_committer 2021-06-01 16:07:35 UTC
(In reply to Rob Zinkov from comment #4)
Applied successfully, now testing in my poudriere.
Comment 6 commit-hook freebsd_committer 2021-06-01 16:26:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a8be2b7a2ecc95a148bbf0467e2edff86434b6e

commit 2a8be2b7a2ecc95a148bbf0467e2edff86434b6e
Author:     Rob Zinkov <rzinkov@gmail.com>
AuthorDate: 2021-06-01 15:59:05 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-06-01 16:24:15 +0000

    audio/moc: Update OPTIONS_DEFAULT to include WAVPACK

    Include wavpack so the audio player can support more audio formats

    PR:             256275

 audio/moc/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)