Bug 256276 - devel/qt5-concurrent: unbreak with gcc11 via upstream
Summary: devel/qt5-concurrent: unbreak with gcc11 via upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (Team)
URL: https://codereview.qt-project.org/c/q...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-05-31 01:36 UTC by Jan Beich
Modified: 2021-06-28 08:45 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kde)


Attachments
v1 (apply via "git am") (2.10 KB, patch)
2021-05-31 01:36 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-05-31 01:36:27 UTC
Created attachment 225389 [details]
v1 (apply via "git am")

Building emulators/yuzu-qt5 with DEFAULT_VERSIONS+=gcc=11 fails but Qt upstream has a fix (see URL).

In file included from /usr/local/include/qt5/QtConcurrent/qtconcurrentiteratekernel.h:49,
                 from /usr/local/include/qt5/QtConcurrent/qtconcurrentfilterkernel.h:47,
                 from /usr/local/include/qt5/QtConcurrent/qtconcurrentfilter.h:47,
                 from /usr/local/include/qt5/QtConcurrent/QtConcurrent:8,
                 from src/yuzu/main.cpp:66:
/usr/local/include/qt5/QtConcurrent/qtconcurrentthreadengine.h:250:50: error: invalid declarator before '*' token
  250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
      |                                                  ^
/usr/local/include/qt5/QtConcurrent/qtconcurrentthreadengine.h:250:49: error: expected ')' before '*' token
  250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
      |                              ~                  ^~
      |                                                 )
Comment 1 commit-hook freebsd_committer 2021-06-28 08:43:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a4a75822cf3861bf72133544b9e048ece7914717

commit a4a75822cf3861bf72133544b9e048ece7914717
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-06-28 08:37:25 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-06-28 08:42:46 +0000

    devel/qt5-concurrent: fix build with gcc11

    Build errors from misplaced template specialization:
      250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
          |                                                  ^
      250 |     ThreadEngineStarter<void>(ThreadEngine<void> *_threadEngine)
          |                              ~                  ^~

    PR:             256276
    Reported by:    jbeich
    Obtained from:  https://codereview.qt-project.org/c/qt/qtbase/+/339417

 devel/qt5-concurrent/Makefile                |  2 +-
 devel/qt5-concurrent/files/patch-gcc11 (new) | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)