Bug 256333 - x11-toolkits/gtk40: enable VULKAN by default
Summary: x11-toolkits/gtk40: enable VULKAN by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
Keywords: patch
Depends on: 256344
  Show dependency treegraph
Reported: 2021-06-01 12:00 UTC by Jan Beich
Modified: 2021-06-01 17:40 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

v1 (apply via "git am") (1.66 KB, patch)
2021-06-01 12:00 UTC, Jan Beich
tcberner: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-06-01 12:00:52 UTC
Created attachment 225449 [details]
v1 (apply via "git am")

Vulkan is a non-default rendering backend. Upstream builds it by default if dependencies are found. Vulkan in Gtk4 maybe useful for consumers that already use Vulkan e.g., multimedia, emulators, games. In general, OPENGL + VULKAN are similar to X11 + WAYLAND, both are going to coexist for years.

# Need mesa-devel for overlay due to bug 250304
$ pkg install gtk4 mesa-dri mesa-devel

Comment 1 Tobias C. Berner freebsd_committer 2021-06-01 12:59:47 UTC
Ship it.
Comment 2 commit-hook freebsd_committer 2021-06-01 14:17:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5d572b40b8be0229fcfa3a667a9bff44713b449

commit a5d572b40b8be0229fcfa3a667a9bff44713b449
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-30 16:40:36 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-06-01 14:14:54 +0000

    x11-toolkits/gtk40: enable VULKAN by default

    Vulkan has to be explicitly enabled at runtime e.g.,

      $ GSK_RENDERER=vulkan gtk4-demo

    PR:             256333
    Inspired by:    Alpine, AOSC, Arch, Ataraxia, Debian, KaOS, Mageia, Nix, openmamba, OpenMandriva, openSUSE, Pisi, Void
    Approved by:    tcberner

 x11-toolkits/gtk40/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer 2021-06-01 14:17:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ee3b1cca9a512b7773d0f17a31eb57e2569996f

commit 4ee3b1cca9a512b7773d0f17a31eb57e2569996f
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-06-01 13:40:11 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-06-01 14:14:53 +0000

    x11-toolkits/gtk40: add missing VULKAN file

    $ make check-plist
    Error: Orphaned: include/gtk-4.0/gsk/vulkan/gskvulkanrenderer.h

    PR:             256333
    Approved by:    tcberner

 x11-toolkits/gtk40/pkg-plist | 1 +
 1 file changed, 1 insertion(+)