Bug 256371 - net/exabgp4: upstream fix for staying in a loop in which it will never connect
Summary: net/exabgp4: upstream fix for staying in a loop in which it will never connect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-02 08:32 UTC by Borja Marcos
Modified: 2021-11-11 12:54 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (zi)


Attachments
patch to solve the closed socket selflock (426 bytes, patch)
2021-09-01 09:25 UTC, Borja Marcos
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Borja Marcos 2021-06-02 08:32:22 UTC
There is a serious bug in ExaBGP including the latest version (4.2.20, while the port is still on 4.2.11).

Depending on network conditions and the number of configured neighbors, ExaBGP may stay in a loop in which it will never connect to them. This bug can be triggered after a power blackout, for example, when it can take some time for connectivity to be restored.

The bug is fixed on Github:
https://github.com/Exa-Networks/exabgp/issues/1035

but it hasn't made it to a numbered release. It will for 4.2.21 I imagine.

Meanwhile, as the fix only requires adding two obvious code lines to a file I think it would be wise to add the patch to the port until 4.2.21 is released.

https://github.com/borjam/exabgp/commit/6c2bf6ff8fd2fbcaa2a0abf621134ec0afa81849
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2021-06-02 13:35:16 UTC
Committed, thanks!
Comment 2 Borja Marcos 2021-09-01 09:21:19 UTC
The bug is back, my fault actually.

I reported it for 4.2.11 and it was added to the master branch but I didn't notice 4.2.13 actually existed.

So,the same patch needs to be applied to 4.2.13.
Comment 3 Borja Marcos 2021-09-01 09:25:42 UTC
Created attachment 227586 [details]
patch to solve the closed socket selflock
Comment 4 Borja Marcos 2021-09-01 09:25:57 UTC
The bug is back on 4.2.13.
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2021-11-11 12:54:54 UTC
Committed again to _2