Bug 256378 - mail/sylpheed - unecessary dependencies
Summary: mail/sylpheed - unecessary dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-02 12:17 UTC by tigersharke
Modified: 2021-06-06 10:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
output of pkg info for sylpheed and gtkspell (2.72 KB, text/plain)
2021-06-02 12:17 UTC, tigersharke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description tigersharke 2021-06-02 12:17:54 UTC
Created attachment 225497 [details]
output of pkg info for sylpheed and gtkspell

The gtkspell option for this port causes a dependency upon dbus which gtkspell itself does not depend upon. Both built fine without dbus as illustrated by the pkg info output attached.
Comment 1 Emanuel Haupt freebsd_committer 2021-06-03 21:14:11 UTC
If you add

DEVELOPER=yes

to /etc/make.conf

remove the dbus dependency and build the port you'll get:

Error: /usr/local/bin/sylpheed is linked to /usr/local/lib/libharfbuzz.so.0 from print/harfbuzz but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libharfbuzz.so:print/harfbuzz
Error: /usr/local/bin/sylpheed is linked to /usr/local/lib/libdbus-glib-1.so.2 from devel/dbus-glib but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libdbus-glib-1.so:devel/dbus-glib
Error: /usr/local/bin/sylpheed is linked to /usr/local/lib/libdbus-1.so.3 from devel/dbus but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libdbus-1.so:devel/dbus

so in fact it needs dbus plus it's missing print/harfbuzz as it seems.
Comment 2 commit-hook freebsd_committer 2021-06-06 10:43:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=06caa0418884a026c1c2e0be94675880371898f4

commit 06caa0418884a026c1c2e0be94675880371898f4
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2021-06-06 10:41:40 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2021-06-06 10:41:40 +0000

    mail/sylpheed: Add missing dependency

    PR:             256378 (based on)
    Notified by:    stage-qa
    MFH:            2021Q1

 mail/sylpheed/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer 2021-06-06 10:46:07 UTC
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=14239f27d1169ace26d1913ce7fd1ba0ac097eba

commit 14239f27d1169ace26d1913ce7fd1ba0ac097eba
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2021-06-06 10:41:40 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2021-06-06 10:45:30 +0000

    mail/sylpheed: Add missing dependency

    PR:             256378 (based on)
    Notified by:    stage-qa
    MFH:            2021Q1

    (cherry picked from commit 06caa0418884a026c1c2e0be94675880371898f4)

 mail/sylpheed/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)