Bug 256389 - [PATCH] acpi: Include Samsung laptops in the x2APIC Sandy Bridge blacklist
Summary: [PATCH] acpi: Include Samsung laptops in the x2APIC Sandy Bridge blacklist
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Some People
Assignee: Konstantin Belousov
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-06-02 19:55 UTC by David Sebek
Modified: 2021-06-10 00:49 UTC (History)
2 users (show)

See Also:


Attachments
Include Samsung laptops/computers in the x2APIC Sandy Bridge blacklist. (1.21 KB, patch)
2021-06-02 19:55 UTC, David Sebek
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Sebek 2021-06-02 19:55:40 UTC
Created attachment 225509 [details]
Include Samsung laptops/computers in the x2APIC Sandy Bridge blacklist.

Almost always, my Samsung RF511 laptop could not boot with
x2APIC enabled in the kernel. It froze during SMP initialization,
shortly after "ACPI APIC Table: <SECCSD LH43STAR>" was printed
to the console. When the kernel is instructed not to use x2APIC,
the system boots correctly.
Comment 1 Konstantin Belousov freebsd_committer 2021-06-02 22:45:50 UTC
I did some additional refactoring, please see
https://reviews.freebsd.org/D30624
Comment 2 David Sebek 2021-06-03 16:08:05 UTC
(In reply to Konstantin Belousov from comment #1)
I tested the refactored patch. It works. Thank you!
Comment 3 commit-hook freebsd_committer 2021-06-03 19:48:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=37f780d3e0a2e8e4c64c526b6e7dc77ff6b91057

commit 37f780d3e0a2e8e4c64c526b6e7dc77ff6b91057
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-06-02 22:29:07 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-06-03 19:47:31 +0000

    Disable x2APIC for SandyBridge laptops with Samsung BIOS

    From the PR:
    Almost always, my Samsung RF511 laptop could not boot with
    x2APIC enabled in the kernel. It froze during SMP initialization,
    shortly after "ACPI APIC Table: <SECCSD LH43STAR>" was printed
    to the console. When the kernel is instructed not to use x2APIC,
    the system boots correctly.

    PR:     256389
    Submitted by:   David Sebek <dasebek@gmail.com>
    Reviewed by:    markj
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D30624

 sys/x86/acpica/madt.c | 1 +
 1 file changed, 1 insertion(+)
Comment 4 commit-hook freebsd_committer 2021-06-10 00:49:12 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c04954bb39d807860d27ffe867d86c1f12465f6e

commit c04954bb39d807860d27ffe867d86c1f12465f6e
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-06-02 22:29:07 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-06-10 00:47:50 +0000

    Disable x2APIC for SandyBridge laptops with Samsung BIOS

    PR:     256389

    (cherry picked from commit 37f780d3e0a2e8e4c64c526b6e7dc77ff6b91057)

 sys/x86/acpica/madt.c | 1 +
 1 file changed, 1 insertion(+)