Bug 256496 - Regression after Fix of Bug #255971
Summary: Regression after Fix of Bug #255971
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-pf (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 08:28 UTC by Rumen Palov
Modified: 2021-06-09 09:12 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rumen Palov 2021-06-09 08:28:16 UTC
Hello all,

after the fix of Bug# 255971 was published, we updated our affected server to test it.

When we execute pfctl -ss the command never ends. 

We have around 150k-200k states in the table pf state table.
This is the source version: 

FreeBSD 13.0-STABLE FreeBSD 13.0-STABLE #6 r3823049: Mon May 31 19:08:28 EEST 2021

Repository Root: https://github.com/freebsd/freebsd
Repository UUID: ac3bce37-e00e-a0fb-6506-ce57b7db7bff
Revision: 3823049
Node Kind: directory
Schedule: normal
Last Changed Author: richard.scheffenegger
Last Changed Rev: 3823049
Last Changed Date: 2021-05-31 09:56:34 +0300 (Mon, 31 May 2021)
Comment 1 Kristof Provost freebsd_committer 2021-06-09 08:45:21 UTC
(In reply to Rumen Palov from comment #0)
It will eventually end, but there's a performance issue in the nvlist code itself with really terrible scaling as arrays grow. It's especially visible on getstate operations, because those can return a large number of items (this very visibly demonstrating the problem).

A fix is expected soon.
Comment 2 Rumen Palov 2021-06-09 09:11:28 UTC
Is that issue with nvlist code affect other parts of the OS ?
Comment 3 Kristof Provost freebsd_committer 2021-06-09 09:12:16 UTC
(In reply to Rumen Palov from comment #2)
Yes, if they have nvlist arrays in their nvlists. I don't know what other parts of the kernel do so.