Bug 256576 - net-p2p/jackett: Update to 0.18.303
Summary: net-p2p/jackett: Update to 0.18.303
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/Jackett/Jackett/co...
Keywords: needs-qa
Depends on: 255710
Blocks:
  Show dependency treegraph
 
Reported: 2021-06-13 12:59 UTC by Michiel van Baak Jansen
Modified: 2021-10-04 12:51 UTC (History)
1 user (show)

See Also:


Attachments
0001-net-p2p-jackett-Update-to-0.18.303.patch (5.50 KB, text/plain)
2021-06-13 12:59 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details
Patch covering PR255710 and PR198727 (5.19 KB, patch)
2021-10-03 17:25 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel van Baak Jansen 2021-06-13 12:59:44 UTC
Created attachment 225767 [details]
0001-net-p2p-jackett-Update-to-0.18.303.patch

Update to 0.18.303

Depends on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255710 to make it work on anything newer then freebsd 11

running in production on my setup (FreeBSD 13 amd64)
Comment 1 Michiel van Baak Jansen 2021-06-13 13:02:21 UTC
Project does not provide CHANGELOG or anything. URL points to github compare page.
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2021-07-07 19:36:14 UTC
Dear Michiel,

I'm sorry for the delay but I was really busy the past weeks, and didn't take
time to give you at least a feedback.

My plan was to wait for the quarter branch was committed (it was the 3/7).
This branch is supposed to be the last one for FreeBSD 11 (EOL was planned for September).

At this point I think we can update the port and mark the port unavailable for FreeBSD before 12.0 without major issue.

Next week I gonna have a couple of days of vacation, so I can probably focus a
little bit more on this ticket.

Thank you for your patience 
Cheers
-- rodrigo
Comment 3 Michiel van Baak Jansen 2021-08-05 13:50:03 UTC
Anything I can do to help you get this one committed?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-24 00:27:37 UTC
^Triage: Reset assignee, open to take.

@Michiel Confirmation of QA (portlint, poudriere) for the attached patch would be great. Logs not required

If the update should be merged to quarterly (primarily bugfixes or includes a security update) please set merge-quarterly to ?
Comment 5 Michiel van Baak Jansen 2021-09-24 08:54:16 UTC
portlint -C ok
poudriere ok, runs on my FreeBSD 13 amd64 jail in 'production'
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2021-10-03 17:25:16 UTC
Created attachment 228407 [details]
Patch covering PR255710 and PR198727

Michiel,

I merge both patches from #255710 and #198727
fix some issues integrating both patches, and add
an the IGNORE if we try to build jackett for a FreeBSD
version under 12.0.

If the merge is working for you we can commit it.

Once again sorry for my laziness.

-- rodrigo
Comment 7 Michiel van Baak Jansen 2021-10-03 17:31:14 UTC
(In reply to Rodrigo Osorio from comment #6)
Dont worry, and thanks for getting back to this one.

To be totally honest, right now it's me being lazy to totally test it.

One small thing:

.if ${OSVERSION} <= 1200000

I think you dont need the = there, as it DOES work on 12.0 and this test is for NEWER then 12.0

Besides that, patch looks good to me and can be committed
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2021-10-04 11:40:20 UTC
(In reply to Michiel van Baak from comment #7)

Yes I fixed this just after sending the message ;)

After reading multiple times the PR and reflection
we can probably just use this form :

.if ${OSVERSION} < 1200000
USES=   mono
.else
RUN_DEPENDS=    mono6.8>0:lang/mono6.8
.endif

If I understand the issue with mono occurs only for freebsd 12.0+
before that one we can keep default mono, right ?

The benefit here is minimal since FreeBSD 11.X is not considered
1 tier anymore, but we still having users with old configs building
their packages by hand
Comment 9 Michiel van Baak Jansen 2021-10-04 12:01:57 UTC
(In reply to Rodrigo Osorio from comment #8)

perfect.

And yes, only on 12.0 and newer we need mono6 for jackett to work. before that, the default mono is ok.
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-10-04 12:49:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b8553f74991faba801b49fd77b77daf350490190

commit b8553f74991faba801b49fd77b77daf350490190
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2021-10-04 12:34:45 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2021-10-04 12:47:16 +0000

    net-p2p/jackett: update to 0.18.303

     * Full changelog: https://github.com/Jackett/Jackett/releases

     * For FreeBSD versions >= 12.0-RELEASE
       Remove USE=mono (mono 5.10) who causes Jackett crashes due
       to the FileSystemWatcher (kevent) deadlock problem (PR #198727)
       replaced by a RUN_DEPENDS on mono 6.8.
       After FreeBSD 12.0 is no longer possible to run Jackett and an
       applications such as radarr or sonarr who was built against default
       mono version on the same computer.

    PR:             255710
    PR:     256576
    Reported by:    Michiel van Baak <michiel@vanbaak.eu>

 net-p2p/jackett/Makefile  |  8 ++++++--
 net-p2p/jackett/distinfo  |  6 +++---
 net-p2p/jackett/pkg-plist | 14 ++++++--------
 3 files changed, 15 insertions(+), 13 deletions(-)
Comment 11 Rodrigo Osorio freebsd_committer freebsd_triage 2021-10-04 12:51:18 UTC
Committed, thanks for your patience.