Bug 256577 - [patch] emulators/uae fix for duplicate symbol error
Summary: [patch] emulators/uae fix for duplicate symbol error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-13 14:31 UTC by sirdice
Modified: 2021-06-15 04:27 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (simond)


Attachments
git diff to fix duplicate symbol error. (731 bytes, patch)
2021-06-13 14:31 UTC, sirdice
no flags Details | Diff
git diff to fix duplicate symbol error. (872 bytes, patch)
2021-06-13 14:39 UTC, sirdice
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sirdice 2021-06-13 14:31:30 UTC
Created attachment 225768 [details]
git diff to fix duplicate symbol error.

Attached git diff should fix the duplicate symbol error it was having. The stuct socketbase in socketbase.h should be defined as external.
Comment 1 sirdice 2021-06-13 14:39:12 UTC
Created attachment 225769 [details]
git diff to fix duplicate symbol error.

Oops. Forgot to update the port's revision.
Comment 2 commit-hook freebsd_committer 2021-06-15 04:25:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9041a8ad49dbd033363fac75c02baf9723871af4

commit 9041a8ad49dbd033363fac75c02baf9723871af4
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-06-15 04:23:34 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-06-15 04:23:48 +0000

    emulators/uae: the port had been improved (+)

    - Unbreak the build on modern FreeBSD versions by avoiding
      injecting duplicate symbols in the object files
    - Drop MAKE_JOBS_UNSAFE: it was added back in 2013 in the
      commit 2a5c8652e56c1 to fix the build error:

        crt1.c:(.text+0xa8): undefined reference to `main'
        gmake[2]: *** [build68k] Error 1

      which no longer manifests itself

    PR:     256577

 emulators/uae/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Comment 3 Alexey Dokuchaev freebsd_committer 2021-06-15 04:27:32 UTC
Committed, thank you!

(In reply to sirdice from comment #1)
> Oops. Forgot to update the port's revision.
Not needed for the build fix.