Bug 256626 - lang/tcl87: add dependency on math/libtommath
Summary: lang/tcl87: add dependency on math/libtommath
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-15 19:29 UTC by m.ne
Modified: 2021-06-16 13:55 UTC (History)
3 users (show)

See Also:


Attachments
Patch adding dependency on math/libtommath (423 bytes, patch)
2021-06-15 19:29 UTC, m.ne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description m.ne 2021-06-15 19:29:48 UTC
Created attachment 225835 [details]
Patch adding dependency on math/libtommath

When trying to build x11-toolkits/py-tkinter with the latest tcl87 the build failed. Adding math/libtommath as a run-time dependency fixed the build for me. An alternative approach might be to patch out the offending #include from tclTomMath.h, but the dependency route seemed easier (and cleaner) to me.

The relevant part of the build log:

===>  Building for py38-tkinter-3.8.10_6
running build
running build_ext
building '_tkinter' extension
creating build
creating build/temp.freebsd-13.0-STABLE-amd64-3.8
cc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DWITH_APPINIT=1 -I/usr/local/include -I/usr/local/include/tcl8.7 -I/usr/local/include/tk8.7 -I/usr/local/include -I/usr/local/include/python3.8 -c _tkinter.c -o build/temp.freebsd-13.0-STABLE-amd64-3.8/_tkinter.o
In file included from _tkinter.c:60:
/usr/local/include/tcl8.7/tclTomMath.h:43:13: fatal error: 'tommath.h' file not found
#   include "tommath.h"
            ^~~~~~~~~~~
1 error generated.
error: command 'cc' failed with exit status 1
*** Error code 1

Stop.
make: stopped in /usr/ports/x11-toolkits/py-tkinter
Comment 1 Alexey Dokuchaev freebsd_committer 2021-06-16 04:42:28 UTC
Over to de facto Tcl/Tk maintainer.
Comment 2 commit-hook freebsd_committer 2021-06-16 13:48:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=45e72f3706b29836a37af8356a1851e2f5bf0be9

commit 45e72f3706b29836a37af8356a1851e2f5bf0be9
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2021-06-16 13:46:15 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2021-06-16 13:47:30 +0000

    lang/tcl87: use libtommath from ports

    PR:             256626
    Reported by:    m.ne@gmx.net

 lang/tcl87/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)