Bug 256646 - databases/sqlite3: revert 255526 and 255839
Summary: databases/sqlite3: revert 255526 and 255839
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-16 14:01 UTC by Pietro Cerutti
Modified: 2021-07-24 10:05 UTC (History)
3 users (show)

See Also:
pavelivolkov: maintainer-feedback+


Attachments
patch (1.93 KB, patch)
2021-06-21 13:12 UTC, Pavel Volkov
pavelivolkov: maintainer-approval-
Details | Diff
patch databases/sqlite3 (5.44 KB, patch)
2021-07-10 12:31 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
patch databases/tcl-sqlite3 (2.94 KB, patch)
2021-07-10 12:35 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
poudriere log (56.10 KB, text/plain)
2021-07-10 12:36 UTC, Pavel Volkov
no flags Details
poudriere log: databases/sqlite3@icu (59.84 KB, text/plain)
2021-07-10 12:38 UTC, Pavel Volkov
no flags Details
poudriere log: "databases/sqlite3@tcl". (68.56 KB, text/plain)
2021-07-10 12:39 UTC, Pavel Volkov
no flags Details
poudriere log for slave port: databases/tcl-sqlite3 (54.06 KB, text/plain)
2021-07-10 12:40 UTC, Pavel Volkov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti freebsd_committer 2021-06-16 14:01:46 UTC
#255526 is wrong: sqlite3 and sqlite3-tcl cannot coexist, so if I want the Tcl extension I cannot have anything that depends on sqlite3 anymore, e.g., gnupg.

#255839 is wronger: removing tcl-sqlite3 puts me in the position not to be able to have the Tcl extension and gnupg.

I kindly ask to revert those two changes OR fix the sqlite3-tcl extension as a subpackage, or - if you want flavor - as a flavor that only installs the Tcl extension files, so I can have both sqlite3 and sqlite3-tcl installed at the same time.

I don't know about the ICU part.
Comment 1 Koichiro Iwao freebsd_committer 2021-06-20 02:42:57 UTC
(In reply to Pietro Cerutti from comment #0)
Sorry about that and thanks so much for the care. I have no objections to revert that. It's up to the maintainer.
Comment 2 Pavel Volkov 2021-06-20 11:08:38 UTC
(In reply to Pietro Cerutti from comment #0)
Hello. Thank you for your attention.
I am currently investigating the possibility of using "flavor" to coexist both packages.
Comment 3 Pavel Volkov 2021-06-21 13:12:30 UTC
Created attachment 225963 [details]
patch

Hello. Technically "flavor" mechanism may be used. But, his don't allow used. Metadata checker out error:

[00:00:07] Gathering ports metadata
[00:00:07] Error: databases/sqlite3@tcl incorrectly depends on itself. Please contact maintainer of the port to fix this.
[00:00:07] Error: Error processing dependencies

This is sad.
Comment 4 Pietro Cerutti freebsd_committer 2021-06-23 09:24:23 UTC
So what are we going to do? tcl-sqlite3 expires in 7 days from now. I am going to be in vacation the first 2 weeks of July so I won't be able to follow up on this.

How about we just revert the two commits and you can think of a better solution without time pressure?
Comment 5 Pavel Volkov 2021-06-23 10:43:54 UTC
(In reply to Pietro Cerutti from comment #4)

Hello.
I am currently investigating the possibility of making tcl-sqlite3 a slave port of sqlite3. In my free time.
The tcl-sqlite3 port is lagging behind sqlite3.

I agree to undo the last commits of the tcl-sqlite3 port.
Comment 6 commit-hook freebsd_committer 2021-06-23 12:24:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2d22538579cf2ed2eaa6d3c9c619b701b9dfdb95

commit 2d22538579cf2ed2eaa6d3c9c619b701b9dfdb95
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2021-06-23 12:21:13 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2021-06-23 12:23:33 +0000

    databases/tcl-sqlite3: Revert "databases/tcl-sqlite3: Deprecate port"

    This reverts commit 14e00e7143dab7e770dcbfc1366d58eb4b61aaef.

    PR:     256646

 databases/tcl-sqlite3/Makefile | 3 ---
 1 file changed, 3 deletions(-)
Comment 7 Pavel Volkov 2021-07-10 12:31:59 UTC
Created attachment 226342 [details]
patch databases/sqlite3

Hello.
I added support for port "databases/tcl-sqlite3" as slave port.
Added CONFLICTS_INSTALL for "default" flavor.

Please, apply both patch for "databases/sqlite3" and "databases/tcl-sqlite3" ports at the same time.
Comment 8 Pavel Volkov 2021-07-10 12:35:16 UTC
Created attachment 226343 [details]
patch databases/tcl-sqlite3

Patch for "databases/tcl-sqlite3" as slave port to "databases/sqlite3".
Comment 9 Pavel Volkov 2021-07-10 12:36:42 UTC
Created attachment 226344 [details]
poudriere log

Poudriere log: "databases/sqlite3".
Comment 10 Pavel Volkov 2021-07-10 12:38:24 UTC
Created attachment 226345 [details]
poudriere log: databases/sqlite3@icu

Poudriere log: "databases/sqlite3@icu".
Comment 11 Pavel Volkov 2021-07-10 12:39:10 UTC
Created attachment 226346 [details]
poudriere log: "databases/sqlite3@tcl".

Poudriere log: "databases/sqlite3@tcl".
Comment 12 Pavel Volkov 2021-07-10 12:40:21 UTC
Created attachment 226347 [details]
poudriere log for slave port: databases/tcl-sqlite3

Poudriere log: "databases/tcl-sqlite3".
Comment 13 Pietro Cerutti freebsd_committer 2021-07-19 06:34:25 UTC
Sorry I don't get (part of) this. I think tcl-sqlite3 being a slave port of sqlite3 is fine, but you also want to keep the -tcl flavour? What's that for?
Comment 14 Pavel Volkov 2021-07-24 10:05:18 UTC
(In reply to Pietro Cerutti from comment #13)
Hello.
Perhaps someone has already used "tcl" flavor in their projects.
Only because of this.
Thanks.