Bug 256655 - devel/godot: fix build on riscv64
Summary: devel/godot: fix build on riscv64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: riscv Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-16 19:28 UTC by Piotr Kubaj
Modified: 2021-06-17 10:29 UTC (History)
2 users (show)

See Also:
FreeBSD: maintainer-feedback+

Attachments
patch (1.06 KB, patch)
2021-06-16 19:28 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2021-06-16 19:28:28 UTC 
Created attachment 225869 [details]
patch

pcre2 currently doesn't support JIT on riscv64. While it's possible to just disable that in godot, this will mean someone will need to remember to enable it when JIT is supported.

This patch makes godot use the system pcre2.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2021-06-17 10:28:54 UTC 
Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-06-17 10:29:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f49ea08b3e5972490fb4861c827a2880f306deea

commit f49ea08b3e5972490fb4861c827a2880f306deea
Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
AuthorDate: 2021-06-17 10:28:02 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2021-06-17 10:28:02 +0000

    devel/godot: fix build on riscv64

    pcre2 currently doesn't support JIT on riscv64. While it's possible to just disable that in godot, this will mean someone will need to remember to enable it when JIT is supported.

    PR:     256655
    Approved by: FreeBSD@ShaneWare.Biz (maintainer)

 devel/godot/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)