Bug 256656 - net-mgmt/icingaweb2: Fix with php 8.0
Summary: net-mgmt/icingaweb2: Fix with php 8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-16 19:36 UTC by Guido Falsi
Modified: 2021-06-18 14:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lme)


Attachments
patch (46.95 KB, patch)
2021-06-16 19:36 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2021-06-16 19:36:46 UTC
Created attachment 225870 [details]
patch

Hi,

I'm in the process of migrating some machines to php 8.0.

I noticed that icingaweb 2.8.2 does not work properly with the new PHP. The server hangs on requests in php-fpm.

Upstream performed two commits that fix this, I've created a patch to import those commits from upstream.

The relevant commits are:

https://github.com/Icinga/icingaweb2/commit/4bc5350ebaaeb7a60bbe20829a1d72def343a921

https://github.com/Icinga/icingaweb2/commit/dc7a8c8d8b6eefe03a5dd66425132de3f1afdc59

I named the new patches after the commit hashes due to lack of a better name.

With these patches it works fine with php 8.0. Also note that upstream has committed further improvements in relation to php 8.0, but these two are sufficient to get proper functionality.

I think this should be added to the official tree.
Comment 1 Lars Engels freebsd_committer 2021-06-18 11:11:18 UTC
Looks good to me. Do you like to commit it yourself?
Comment 2 Guido Falsi freebsd_committer 2021-06-18 13:58:41 UTC
Thanks, I'll commit it shortly!
Comment 3 commit-hook freebsd_committer 2021-06-18 14:46:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c7ba3d9534456e7c2b18811765e79cb1cad31082

commit c7ba3d9534456e7c2b18811765e79cb1cad31082
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-06-18 14:42:32 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-06-18 14:45:53 +0000

    net-mgmt/icingaweb2: Fix at runtime with php 8

    PR:             256656
    Approved by:    lme (maintainer)
    Obtained from:  https://github.com/Icinga/icingaweb2/commit/4bc5350ebaaeb7a60bbe20829a1d72def343a921
                    https://github.com/Icinga/icingaweb2/commit/dc7a8c8d8b6eefe03a5dd66425132de3f1afdc59

 net-mgmt/icingaweb2/Makefile                       |    1 +
 net-mgmt/icingaweb2/files/patch-4bc5350ebaae (new) | 1054 ++++++++++++++++++++
 net-mgmt/icingaweb2/files/patch-dc7a8c8d8b6e (new) |  193 ++++
 3 files changed, 1248 insertions(+)
Comment 4 Guido Falsi freebsd_committer 2021-06-18 14:47:28 UTC
Patch committed.

Thanks!