Bug 256664 - security/acme.sh: Fix sed -i
Summary: security/acme.sh: Fix sed -i
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-17 06:58 UTC by Freddy DISSAUX
Modified: 2021-06-19 17:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dvl)


Attachments
Makefile patch fix sed -i (496 bytes, patch)
2021-06-17 06:58 UTC, Freddy DISSAUX
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Freddy DISSAUX 2021-06-17 06:58:00 UTC
Created attachment 225884 [details]
Makefile patch fix sed -i

FreeBSD sed -i require extension.

This patch fix dnsapi/dns_nsd.sh.
Comment 1 Dan Langille freebsd_committer 2021-06-18 18:28:38 UTC
In my poudriere testport:

root@13amd64-dvl:~ # pkg info -l acme.sh | grep dns_nsd.sh
	/usr/local/share/examples/acme.sh/dnsapi/dns_nsd.sh
root@13amd64-dvl:~ # grep sed /usr/local/share/examples/acme.sh/dnsapi/dns_nsd.sh
  sed -i bak "/$fulldomain. $ttlvalue IN TXT \"$txtvalue\"/d" "$Nsd_ZoneFile"
root@13amd64-dvl:~ #
Comment 2 commit-hook freebsd_committer 2021-06-18 18:33:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f5536c9ffda14d1e472154afef38a721f19f3263

commit f5536c9ffda14d1e472154afef38a721f19f3263
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2021-06-18 18:31:06 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2021-06-18 18:32:22 +0000

    security/acme.sh: ensure sed -i works in examples/acme.sh/dnsapi/dns_nsd.sh

    PR:             256664
    Reported by:    Freddy DISSAUX <dsx@bsdsx.fr>

 security/acme.sh/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 3 Dan Langille freebsd_committer 2021-06-18 18:33:55 UTC
Thank you.  I'll also contact the author.
Comment 4 Dan Langille freebsd_committer 2021-06-18 19:10:18 UTC
See also upstream: https://github.com/acmesh-official/acme.sh/issues/3563
Comment 5 Dan Langille freebsd_committer 2021-06-19 17:07:13 UTC
This is now patched upstream. testport here shows their patch comes through. Do you want to try the acme.sh dev branch now or wait until the next release?