Bug 256669 - graphics/opencv fetches 3rd party distfiles in the configure phase
Summary: graphics/opencv fetches 3rd party distfiles in the configure phase
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-17 11:56 UTC by Stefan Eßer
Modified: 2021-07-18 10:55 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Eßer freebsd_committer 2021-06-17 11:56:32 UTC
In the configure phase I got the following output:

-- Checking for module 'gtk+-3.0'
--   Found gtk+-3.0, version 3.24.29
-- Checking for module 'gthread-2.0'
--   Found gthread-2.0, version 2.66.8
-- IPPICV: Download: ippicv_2020_lnx_intel64_20191018_general.tgz
-- found Intel IPP (ICV version): 2020.0.0 [2020.0.0 Gold]
-- at: /usr/work/usr/git/ports/graphics/opencv/work/.build/3rdparty/ippicv/ippicv_lnx/icv
-- found Intel IPP Integration Wrappers sources: 2020.0.0
-- at: /usr/work/usr/git/ports/graphics/opencv/work/.build/3rdparty/ippicv/ippicv_lnx/iw

It seems that these required files are not fetched and checked in the fetch/checksum phases.

I have no idea how this is supposed to work with poudriere - the log is from a simple "make" in the port directory to diagnose the issue.
Comment 1 Stefan Eßer freebsd_committer 2021-06-17 11:58:51 UTC
Adding to the issue with distfiles being downloaded in the configure phase, I got the following output from phase qa:

====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libgtk-3.so.0 from x11-toolkits/gtk30 but it is not declared as a dependency
Warning: you need USE_GNOME+=gtk30
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libgdk-3.so.0 from x11-toolkits/gtk30 but it is not declared as a dependency
Warning: you need USE_GNOME+=gtk30
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency
Warning: you need USE_GNOME+=cairo
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency
Warning: you need USE_GNOME+=gdkpixbuf2
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libgobject-2.0.so.0 from devel/glib20 but it is not declared as a dependency
Warning: you need USE_GNOME+=glib20
Error: /usr/local/lib/libopencv_highgui.so.4.5.1 is linked to /usr/local/lib/libglib-2.0.so.0 from devel/glib20 but it is not declared as a dependency
Warning: you need USE_GNOME+=glib20
Error: /usr/local/lib/libopencv_imgcodecs.so.4.5.1 is linked to /usr/local/lib/libopenjp2.so.7 from graphics/openjpeg but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libopenjp2.so:graphics/openjpeg
Error: /usr/local/lib/libopencv_text.so.4.5.1 is linked to /usr/local/lib/libtesseract.so.4 from graphics/tesseract but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libtesseract.so:graphics/tesseract
Error: /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to /usr/local/lib/libgstbase-1.0.so.0 from multimedia/gstreamer1 but it is not declared as a dependency
Warning: you need to use USE_GSTREAMER1+=yes
Error: /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to /usr/local/lib/libgstreamer-1.0.so.0 from multimedia/gstreamer1 but it is not declared as a dependency
Warning: you need to use USE_GSTREAMER1+=yes
Error: /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to /usr/local/lib/libgstapp-1.0.so.0 from multimedia/gstreamer1-plugins but it is not declared as a dependency
Warning: you need to use USE_GSTREAMER1+=yes
Error: /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to /usr/local/lib/libgstriff-1.0.so.0 from multimedia/gstreamer1-plugins but it is not declared as a dependency
Warning: you need to use USE_GSTREAMER1+=yes
Error: /usr/local/lib/libopencv_videoio.so.4.5.1 is linked to /usr/local/lib/libgstpbutils-1.0.so.0 from multimedia/gstreamer1-plugins but it is not declared as a dependency
Warning: you need to use USE_GSTREAMER1+=yes
Comment 2 Tobias C. Berner freebsd_committer 2021-06-17 15:46:16 UTC
Moin moin 

I will address it with the pending update.


mfg Tobias
Comment 3 commit-hook freebsd_committer 2021-07-18 10:54:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43a30a366ccd676856efe5df2a6b8454158678b6

commit 43a30a366ccd676856efe5df2a6b8454158678b6
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-07-18 09:49:25 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-07-18 10:53:21 +0000

    graphics/opencv: update to 4.5.3

    Changes in the port:
    - fix prefetch of third party software
            - prefetching of distfiles has been fixed
            - cmake will now throw an error in ocv_download()
              if it is still called
    - minor cleanup

    - next step: readd some more options, and improve port for
      non-poudriere users

    PR:             256669

 graphics/opencv/Makefile                           |  43 ++++--
 graphics/opencv/distinfo                           |  16 ++-
 .../files/patch-3rdparty_ippicv_ippicv.cmake (new) |  26 ++++
 .../files/patch-cmake_OpenCVDownload.cmake (new)   |  14 ++
 ...patch-contrib_modules_face_CMakeLists.txt (new) |  28 ++++
 ...rib_modules_wechat__qrcode_CMakeLists.txt (new) |  26 ++++
 ...eatures2d_cmake_download__boostdesc.cmake (new) |  25 ++++
 ...les_xfeatures2d_cmake_download__vgg.cmake (new) |  27 ++++
 .../patch-modules_gapi_cmake_DownloadADE.cmake     |  20 ++-
 .../files/patch-modules_videoio_src_cap__v4l.cpp   |   4 +-
 graphics/opencv/pkg-plist                          | 147 ++++++++++++---------
 11 files changed, 292 insertions(+), 84 deletions(-)
Comment 4 Tobias C. Berner freebsd_committer 2021-07-18 10:55:13 UTC
Moin moin

The prefetching should now be fixed.


mfg Tobias