Bug 256684 - www/chromium with a mixed bag of patches going from v90 to v91
Summary: www/chromium with a mixed bag of patches going from v90 to v91
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-18 07:06 UTC by doctor
Modified: 2021-06-26 09:54 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description doctor 2021-06-18 07:06:23 UTC
Tried to compile www/chromium and it looks like there is  a hodgepog of
old patches stopping the proper fix and compilation.  Can this looked into, and not for chromium, but for all ports.
Comment 1 Rene Ladan freebsd_committer 2021-06-20 10:45:50 UTC
The latest chromium builds fine in poudriere with the default options set. For i386 it might run out of memory during linking.

Can you list for which options chromium does not build, and which other ports you mean (not all 31k right)?
Comment 2 doctor 2021-06-21 00:13:49 UTC
Applying extra patch /usr/ports/www/chromium/files/extra-patch-clang
===>  Applying extra patch /usr/ports/www/chromium/files/extra-patch-build_config_compiler_pgo_pgo.gni
===>  Applying FreeBSD patches for chromium-91.0.4472.114 from /usr/ports/www/chromium/files
1 out of 1 hunks failed--saving rejects to base/bind.h.rej
===>  FAILED Applying FreeBSD patch-base_bind.h
===> Cleanly applied FreeBSD patch(es)  patch-3p-pdfium_3p_base_allocator_partition__allocator_page__allocator__internals__posix.h patch-BUILD.gn patch-apps_app__restore__service__browsertest.cc patch-apps_ui_views_app__window__frame__view.cc patch-ash_display_mirror__window__controller.cc patch-base_BUILD.gn patch-base_allocator_allocator.gni patch-base_allocator_allocator__shim__default__dispatch__to__glibc.cc patch-base_allocator_allocator__shim__override__libc__symbols.h patch-base_allocator_allocator__shim__unittest.cc patch-base_allocator_partition__allocator_address__pool__manager.cc patch-base_allocator_partition__allocator_page__allocator__internals__posix.h patch-base_allocator_partition__allocator_partition__alloc.cc patch-base_allocator_partition__allocator_partition__alloc__config.h patch-base_allocator_partition__allocator_partition__alloc__unittest.cc patch-base_allocator_partition__allocator_partition__root.cc patch-base_allocator_partition__allocator_spinning__mutex.cc patch-base_allocator_partition__allocator_spinning__mutex.h patch-base_allocator_partition__allocator_starscan_pcscan.cc patch-base_base__switches.cc patch-base_base__switches.h
===> FAILED to apply cleanly FreeBSD patch(es)  patch-base_bind.h
Comment 3 Christoph Moench-Tegeder freebsd_committer 2021-06-21 08:58:39 UTC
(In reply to doctor from comment #2)

Your tree is borked: patch-base_bind.h was deleted in
https://cgit.freebsd.org/ports/commit/www/chromium/files?id=06317815238060a3a7f5911f18a3dd7c95779c83
("www/chromium: update to 91.0.4472.101").