Bug 256685 - audio/ripit: Change default settings from freedb to gnudb
Summary: audio/ripit: Change default settings from freedb to gnudb
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-18 07:39 UTC by Michael Gmelin
Modified: 2021-07-11 15:21 UTC (History)
2 users (show)

See Also:
tobias.rehbein: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer 2021-06-18 07:39:13 UTC
Freedb is no more, so it would make sense to change the default to freedb (and the submit address to submit@gnudb.org). Upstream is archived, so such a change would have to happen in the port skeleton.

Happy to provide a patch, if the maintainer agrees to this change.
Comment 1 tobias.rehbein 2021-06-18 09:26:26 UTC
audio/ripit has been marked DEPRECATED in PR 248426 and will be removed from the ports tree in the near future. Therefore I don't think there is any need to patch stuff in the port.
Comment 2 Michael Gmelin freebsd_committer 2021-06-18 11:32:46 UTC
Oh sad - I would like to take maintainership and keep it alive, as it still works fine for me.

I'm not sure about the note on bug #248426 about missing https causing it to break, I've been using it this morning with

  CDDBHOST=gnudb.org
  mirror=gnudb

in ~/.ripit/config and it worked just fine.
Comment 3 tobias.rehbein 2021-06-18 11:42:05 UTC
I was using Musicbrainz for metadata and that failed to fetch, when I tested it.

If you want to take maintainership, feel free :)

Upstream is gone, the port uses an archived version in my github.
Comment 4 Michael Gmelin freebsd_committer 2021-06-18 11:46:55 UTC
(In reply to tobias.rehbein from comment #3)

> the port uses an archived version in my github.

Oh, wasn't aware that this was *your* github...

I'll try audio/abcde first and see if I'm happy with it. If not, I'll takeover audio/ripit before its expiration date.

Thanks for your quick response.
Comment 5 Michael Gmelin freebsd_committer 2021-07-11 15:21:27 UTC
(In reply to tobias.rehbein from comment #3)

> Upstream is gone, the port uses an archived version in my github.

Actually, upstream still exists under http://www.ripit.pl and provides tarballs for download - but no new development is happening.

That said, I finally found some time to play with audio/abcde and I'm happy with the results. So I agree with you that there's no real reason to keep audio/ripit on life support. Therefore I'm closing this PR.

By the way, I use the following ~/.abcde.conf to get output similar to what I got with ripit:

  PADTRACKS=y
  LAMEOPTS="--preset extreme"
  OGGENCOPTS="-q 5"
  EYED3OPTS="--encoding latin1 --non-std-genres"
  OUTPUTDIR=/music/incoming
  OUTPUTTYPE=mp3
  OUTPUTFORMAT='${ARTISTFILE} - ${ALBUMFILE}/${TRACKNUM} ${TRACKFILE}'
  VAOUTPUTFORMAT='Various - ${ALBUMFILE}/${TRACKNUM} ${ARTISTFILE} - ${TRACKFILE}'

  mungefilename ()
  {
    echo "$@" | sed -e 's/^\.*//' | tr -d ":><|*/\"'?[:cntrl:]"
  }

It might make sense to add "--non-std-genres" to the sample configuration, otherwise files stay completely untagged in case of no/an unknown genre (see also https://abcde.einval.com/bugzilla/show_bug.cgi?id=72 ).