Bug 256709 - [NEW PORT] devel/R-cran-gert Simple Git Client for R
Summary: [NEW PORT] devel/R-cran-gert Simple Git Client for R
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-19 09:27 UTC by Jean-Paul Beconne
Modified: 2021-07-05 19:08 UTC (History)
2 users (show)

See Also:


Attachments
Port in GIT diff format (5.37 KB, patch)
2021-06-19 09:27 UTC, Jean-Paul Beconne
no flags Details | Diff
Port in GIT diff format (1.98 KB, patch)
2021-06-29 18:55 UTC, Jean-Paul Beconne
no flags Details | Diff
Pkg-desc modified (1.98 KB, patch)
2021-06-30 18:10 UTC, Jean-Paul Beconne
no flags Details | Diff
Dependencies added (1.98 KB, patch)
2021-07-01 18:15 UTC, Jean-Paul Beconne
no flags Details | Diff
Correct patch after git misuse (2.02 KB, patch)
2021-07-05 18:55 UTC, Jean-Paul Beconne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Paul Beconne 2021-06-19 09:27:36 UTC
Created attachment 225922 [details]
Port in GIT diff format

Require bug 256708 before evaluation
Comment 1 Guangyuan Yang freebsd_committer 2021-06-20 07:39:33 UTC
Your patch includes unrelated stuff (roxygen2), also you need to "hook it to the build" per my comments in PR 256708.
Comment 2 Jean-Paul Beconne 2021-06-29 18:55:33 UTC
Created attachment 226119 [details]
Port in GIT diff format

Dependencies modified
Comment 3 Guangyuan Yang freebsd_committer 2021-06-29 20:14:56 UTC
Could you wrap your pkg-descr file consistently (at 70 characters per line)? Please also explicitly indicate here if this patch passes portlint and build tests.
Comment 4 Jean-Paul Beconne 2021-06-30 18:08:19 UTC
(In reply to Guangyuan Yang from comment #3)
It passes portlint and build tests
Comment 5 Jean-Paul Beconne 2021-06-30 18:10:31 UTC
Created attachment 226138 [details]
Pkg-desc modified

pkg-desc is modified according your last comment. Howevere I don't find any reference on 70 characters formatting in Porter Handbook
Comment 6 Guangyuan Yang freebsd_committer 2021-07-01 09:16:52 UTC
Build failed. Seems to be needing libgit2.

http://jenkins.ygy.io/job/freebsd-ports-testing-13.0R-amd64/308/console
Comment 7 Jean-Paul Beconne 2021-07-01 18:15:33 UTC
Created attachment 226157 [details]
Dependencies added

portlint run fine
test build sequence run fine
Comment 8 Guangyuan Yang freebsd_committer 2021-07-02 09:40:47 UTC
Did you really update the patch? it seems to be exactly the same as the last one.

Also, you seriously need to set up your testing infrastructure with Poudriere - committers' time can't be wasted on keeping running build tests for you. You need to make sure that the build is fine before submitting a patch.
Comment 9 Jean-Paul Beconne 2021-07-05 18:55:00 UTC
Created attachment 226245 [details]
Correct patch after git misuse

Correct patch after misuse of git.
I submit without issue 2-3 other ports.
With the new procedure (git, Makefile of all ports, 70 characters for description), it is more difficult to send a port and I maybe don't have the skills to do it.
So, that's the last try before definitively giving up. What is the procedure to give a port to somebody else ?