Created attachment 225955 [details]
Patch for libiio
Fix compilation with libxml2 2.9.12 and add LDFLAGS to prevent overlinking with iconv (Q/A stage)
Poudriere testport OK 12.2-RELEASE (amd64)
Was there an error message?
What causes overlinking?
It fails to find header files for avahi and overlinks iconv which Poudriere detects (and complains since USES= iconv isn't defined). I didn't look too much into the header file issue, I'm guessing it works by accident as current version in tree of libxml adds a lot of additional include paths.
A commit in branch main references this bug:
Author: Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-06-20 19:14:12 +0000
Commit: Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-06-20 19:15:48 +0000
misc/libiio: Fix compilation with libxml2>=2.9.12 by adding USES=localbase
Reported by: Daniel Engberg <email@example.com>
misc/libiio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(In reply to Daniel Engberg from comment #2)
I added the first part: USES=localbase.
For the iconv part we need to understand the cause of overlinking.
The project itself doesn't add iconv. Does libxml2>=2.9.12 add -liconv redundantly?
(In reply to Yuri Victorovich from comment #4)
According to Uses/iconv.mk, I think libxml2 uses base iconv, so it shouldn't append -liconv.
The port seems to build fine with new libxml2. This can be closed.