Bug 256762 - www/py-google-api-python-client: update to 2.35.0
Summary: www/py-google-api-python-client: update to 2.35.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/googleapis/google-...
Depends on:
Blocks: 261313
  Show dependency treegraph
Reported: 2021-06-21 21:59 UTC by Pavel Timofeev
Modified: 2022-04-08 06:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nivit)

port patch (2.66 KB, patch)
2021-06-21 21:59 UTC, Pavel Timofeev
no flags Details | Diff
port patch (2.72 KB, patch)
2022-01-18 18:17 UTC, Pavel Timofeev
no flags Details | Diff
port patch new (3.13 KB, patch)
2022-01-19 16:35 UTC, Pavel Timofeev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2021-06-21 21:59:03 UTC
Created attachment 225981 [details]
port patch

- actualize RUN_DEPENDS
- Set django22 to version described as needed in distro
- Set WebTest and openssl dependencies as >0 since there is no a strict requirement for their versions

NOTE: The 2.0 release of google-api-python-client is a significant upgrade, see https://github.com/googleapis/google-api-python-client/blob/master/UPGRADING.md
Comment 1 Pavel Timofeev 2022-01-18 18:17:39 UTC
Created attachment 231134 [details]
port patch

Update to 2.35.0
Comment 2 Pavel Timofeev 2022-01-19 16:35:58 UTC
Created attachment 231164 [details]
port patch new

Use proper django considered TLS nowadays
Comment 3 Kai Knoblich freebsd_committer 2022-04-03 11:21:59 UTC
(In reply to Pavel Timofeev from comment #2)

Hi Pavel, thank you for the whole set of patches!

I've only one question at the moment: Do we still need the DJANGO option because the Django samples were removed with the 1.7.9 release? (see also issue #648 and PR #657).

I can't find any references of Django in the Python code of the 2.35 release as well so it might be safe to entirely remove the DJANGO option.
Comment 4 Pavel Timofeev 2022-04-03 14:30:10 UTC
(In reply to Kai Knoblich from comment #3)
Well, I kept DJANGO just because previous releases were referring to it. I'm not really sure django is really needed.
Should I remove it?
Comment 5 Kai Knoblich freebsd_committer 2022-04-03 17:01:16 UTC
(In reply to Pavel Timofeev from comment #4)

No problem and IMHO the DJANGO can be removed as there are no references in the Python code and "setup.{py,cfg}".

For the case if Django is still required in some way we can re-add that option in another commit.

If you like you can update the patch and I'll try to commit it the next few days.
Comment 6 commit-hook freebsd_committer 2022-04-08 05:56:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ad62662e485dd03a22d31d697e6c0dc8619c3255

commit ad62662e485dd03a22d31d697e6c0dc8619c3255
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2022-04-08 05:51:21 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2022-04-08 05:51:21 +0000

    www/py-google-api-python-client: Update to 2.35.0

    * Remove the DJANGO option as the supplied samples for Django projects
      were removed with the 1.7.9 release and the Python code has no more
      references to Django related dependencies.

    Changelog since 1.7.6:


    PR:             256762
    Reported by:    Pavel Timofeev
    Approved by:    maintainer timeout (9+ months)
    MFH:            No (feature release)

 www/py-google-api-python-client/Makefile | 21 +++++++++------------
 www/py-google-api-python-client/distinfo |  6 +++---
 2 files changed, 12 insertions(+), 15 deletions(-)
Comment 7 Kai Knoblich freebsd_committer 2022-04-08 06:13:14 UTC
Committed, thank you for the patches and sorry for the huge delay!