Bug 256821 - graphics/poppler: do not depend on devel/boost-libs
Summary: graphics/poppler: do not depend on devel/boost-libs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-25 05:34 UTC by dmn
Modified: 2021-07-05 20:01 UTC (History)
3 users (show)

See Also:


Attachments
graphics/poppler: do not depend on devel/boost-libs (790 bytes, patch)
2021-06-25 05:34 UTC, dmn
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dmn 2021-06-25 05:34:34 UTC
Created attachment 226047 [details]
graphics/poppler: do not depend on devel/boost-libs

Please, do not bloat dependencies when it's not necessary.

Regards,
Dmitry.
Comment 1 Po-Chuan Hsieh freebsd_committer 2021-06-25 14:01:36 UTC
Assign to maintainer.
Comment 2 commit-hook freebsd_committer 2021-07-05 12:23:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8d6d6af0c7555b0bb2af494ba2b74c92bb7db92

commit d8d6d6af0c7555b0bb2af494ba2b74c92bb7db92
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2021-07-05 09:09:18 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-07-05 12:23:28 +0000

    graphics/poppler: make boost a build-time dependency

    Poppler uses Boost small-vectors for efficiency (over std::vector)
    when the Splash renderer is enabled. Small-vectors are header-only,
    so there is no need to depend on the whole boost-libs at runtime.

    The PR asks to drop Boost entirely; we're not going to do that,
    but as a build-dep it avoids installed-size bloat.

    Bump PORTREVISION also of related ports to make sure they are
    rebuilt; don't need to re-do all consumers because Boost was not
    linked anyway.

    PR:             256821

 graphics/poppler-glib/Makefile  | 2 +-
 graphics/poppler-qt5/Makefile   | 2 +-
 graphics/poppler-utils/Makefile | 2 +-
 graphics/poppler/Makefile       | 5 +++--
 4 files changed, 6 insertions(+), 5 deletions(-)
Comment 3 dmn 2021-07-05 20:00:55 UTC
Thank you!
Comment 4 dmn 2021-07-05 20:01:59 UTC
Thank you!