Bug 256875 - sysutils/radmind: Update to radmind 1.15.4
Summary: sysutils/radmind: Update to radmind 1.15.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-28 19:59 UTC by mikeg
Modified: 2021-06-30 16:01 UTC (History)
1 user (show)

See Also:


Attachments
radmind 1.15.3 -> 1.15.4 patch (1.82 KB, patch)
2021-06-28 19:59 UTC, mikeg
mikeg: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mikeg 2021-06-28 19:59:26 UTC
Created attachment 226093 [details]
radmind 1.15.3 -> 1.15.4 patch

Bump the radmind port to 1.15.4 - this is effectively a NOP for FreeBSD as the change in 1.15.4 only affects MacOS.

Also includes pkg-descr cleanup and a fix to support DESTDIR properly (clears the portlint warning about absolute path /var/radmind ; now ${DESTDIR}/var/radmind).

Ran basic QA: Build/Run checks OK on a clean FreeBSD 12.2 box
portlint is now clean with the DESTDIR fix, but that change could use a spot-check (we don't have Poudriere up and running at work).
Comment 1 Fernando Apesteguía freebsd_committer 2021-06-30 09:49:41 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Q/A:  Makefile: new ports should not set PORTREVISION.

Some variables are out of order:

# USES block                         
USES                                         
USE_RC_SUBR            
                                                            
-MAKE_JOBS_UNSAFE                    
                                                            
# Configure block
GNU_CONFIGURE                                         
CONFIGURE_ARGS                          
                                                            
# Make block                            
+MAKE_JOBS_UNSAFE                                                                                                        
-RADMINUSER                                                                                                              
                                                            
# Standard bsd.port.mk variables
+SUB_FILES                              
+SUB_LIST          
                                                            
# Users and groups block
USERS         
GROUPS                                    
                                                            
-RADMIND_BASE_DIR             
                                                            
-SUB_LIST                                      
                                                            
# Packaging list block                
PLIST_SUB                                                                                                                
                                                            
# Options definitions                            
+OPTIONS_DEFINE                          
-SUB_FILES                             

What are we using PORTREVISION for? Do upstream roll new versions without bumping the version number?

Thanks!
Comment 2 commit-hook freebsd_committer 2021-06-30 16:00:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8dab016d93c375ea8b5812487f39e17027faa996

commit 8dab016d93c375ea8b5812487f39e17027faa996
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2021-06-30 09:59:42 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-06-30 15:54:52 +0000

    sysutils/radmind: Update to radmind 1.15.4

    PR:     256875
    Reported by:    mikeg@bsd-box.net (maintainer)

 sysutils/radmind/Makefile  | 19 +++++++++++--------
 sysutils/radmind/distinfo  |  6 +++---
 sysutils/radmind/pkg-descr |  4 +---
 3 files changed, 15 insertions(+), 14 deletions(-)
Comment 3 Fernando Apesteguía freebsd_committer 2021-06-30 16:01:18 UTC
Committed,

Thanks!