Bug 256877 - security/sequoia and security/py-sequoia: Update 1.3.0
Summary: security/sequoia and security/py-sequoia: Update 1.3.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-06-28 21:15 UTC by phryk-ports
Modified: 2021-06-29 01:41 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (phryk-ports)


Attachments
updates security/sequoia and security/py-sequoia (115.49 KB, patch)
2021-06-28 21:15 UTC, phryk-ports
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description phryk-ports 2021-06-28 21:15:14 UTC
Created attachment 226095 [details]
updates security/sequoia and security/py-sequoia

Sequoia-OpenPGP recently released version `1.3.0`.

Since both sequoia-openpgp (as well as sequoia-sq and sequoia-sqv) and the python bindings live in the same git repo, I'm handing in the updates to both ports in one go. No warnings raised by `portlint` and `make index` runs through without issue.

Some notes:

I added `SONAME`s for the `ffi` and `openpgp-ffi` libs. This isn't possible for `ffi-macros` as it doesn't count as "cdylib". The version supplied in `SONAME` might technically be wrong since they use the `1.3.0` version of the `sequoia-openpgp` crate and not the `0.22.0` of their own crates because this led to issues finding the libs that I couldn't resolve.

Both ports now support the `test` target and the test suites run successfully on the amd64 jail I use for testing purposes – tho for sequoia you first have to install it; otherwise it will fail to find the libs – I assume this is is caused by setting `SONAME`, as the error message specifically mentions `.so.1.3.0` but I haven't been able to properly triage the issue.

`py-sequoia` now has its own version as noted in its `setup.py` (`0.1.0`), hence the version *decreased*.

Also, for future releases, I'll probably break this up into about half a dozen different ports and maybe keep `sequoia´ as a metaport with `OPTION`s for the different crates. `sqop` was already moved into its own repo upstream and isn't part of the sequoia port anymore. I'll add it back as its own port in the future.

Would be super nice if we could get this into the next quarterlies, but I totally understand if the remaining time is a bit short for that. ^_^;
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-29 01:41:15 UTC
(In reply to phryk-ports from comment #0)

PORTEPOCH needs to be incremented when a version goes backward.

Do the changes pass QA (poudriere) for default and non-default Python versions?

If there's a changelog associated with this release, please include it in the URL field. 

If this is a bugfix only release, please set merge-quarterly to ? It can be merged anytime if so.