Bug 256983 - graphics/gimp-app: add missing dependency to math/Imath
Summary: graphics/gimp-app: add missing dependency to math/Imath
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2021-07-04 17:29 UTC by Philipp Ost
Modified: 2021-07-16 17:12 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (gnome)
mandree: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Add missing dependency to math/Imath (782 bytes, patch)
2021-07-04 17:29 UTC, Philipp Ost
no flags Details | Diff
add Imath to OPENEXR_LIB_DEPENDS - suitable as input for git am (1.01 KB, patch)
2021-07-05 22:07 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-07-04 17:29:04 UTC
Created attachment 226224 [details]
Add missing dependency to math/Imath

/usr/local/libexec/gimp/2.2/plug-ins/file-exr/file-exr is linked to /usr/local/lib/libImath-3_0.so.28, but math/Imath is not listed as a library dependency.

The attached patch fixes that.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-05 00:01:07 UTC
^Triage: [tags] in issue Titles are deprecated
Comment 2 Matthias Andree freebsd_committer 2021-07-05 21:59:46 UTC
I think this Imath addition does not belong into the top-level LIB_DEPENDS, but instead it should be listed under the optional OPENEXR_LIB_DEPENDS - it is OpenEXR that requires Imath. Will post a new patch soonish.
Comment 3 Matthias Andree freebsd_committer 2021-07-05 22:07:27 UTC
Created attachment 226252 [details]
add Imath to OPENEXR_LIB_DEPENDS - suitable as input for git am

Let's add Imath as requisite to OPENEXR_LIB_DEPENDS instead, and let's avoid the PORTREVISION bump.
Comment 4 commit-hook freebsd_committer 2021-07-16 16:27:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a81d5444d20fb555f0313f042c99a51ad577ba6c

commit a81d5444d20fb555f0313f042c99a51ad577ba6c
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-07-05 22:04:38 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-07-16 16:26:06 +0000

    graphics/gimp-app: OPENEXR_LIB_DEPENDS+=Imath

    Since Imath is in the port's INDEX and OpenEXR will pull Imath in,
    I think we can forgo a PORTREVISION bump.

    PR:             256983
    Reported by:    Philipp Ost
    MFH:            2021Q3

 graphics/gimp-app/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Matthias Andree freebsd_committer 2021-07-16 17:12:39 UTC
Whoops, this accidentally slipped with another pull, I meant to wait for gnome@'s feedback or maintainer timeout. @gnome@, can we leave this in now, 3 days early?