Created attachment 226235 [details]
ports tree patch to add comms/py-fritzconnection
A Python tool to communicate with the AVM FritzBox family of home routers popular in Germany and other European countries. It uses the TR-064 protocol over UPnP.
Created attachment 226885 [details]
new version 1.6.0
(In reply to Michael Büker from comment #0)
Just to make sure that you have tested the functionality of this port? Can help to commit the port but don't have the hardware for testing.
Thanks! Yes, I've been using it for a few months with appropriate hardware before submitting the port. I haven't checked every bit of functionality, but it basically works as advertised on FreeBSD.
(In reply to Michael Büker from comment #3)
Another thing: It is recommended to add TEST_DEPENDS and a do-test: target if upstream has unit test suites. Can you confirm if tests pass on FreeBSD and could the Makefile be updated if all passed?
I think I need some more guidance concerning the tests :)
Tests exist, and they complete successfully. BUT: They are only included with the Github releases, but not in the PyPi packages.
What should I do?
1) switch the Makefile to fetch from Github instead of PyPi and run tests?
2) stay with PyPi and ignore the tests?
(In reply to Michael Büker from comment #5)
I think Option 1 is better, i.e. switch to Github releases and create the do-test target.
Created attachment 226987 [details]
github source, test-target included
Okay, done and tested to work as expected :)
A commit in branch main references this bug:
Author: Michael Büker <firstname.lastname@example.org>
AuthorDate: 2021-08-06 14:16:44 +0000
Commit: Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-08-06 14:16:44 +0000
comms/py-fritzconnection: New port
Python tool to communicate with AVM FritzBox routers.
comms/Makefile | 1 +
comms/py-fritzconnection/Makefile (new) | 25 +++++++++++++++++++++++++
comms/py-fritzconnection/distinfo (new) | 3 +++
comms/py-fritzconnection/pkg-descr (new) | 4 ++++
4 files changed, 33 insertions(+)
Committed, thank you for the great work!