Bug 256994 - multimedia/mplayer and multimedia/mencoder: add missing dependencies
Summary: multimedia/mplayer and multimedia/mencoder: add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-07-05 14:48 UTC by Philipp Ost
Modified: 2022-08-07 14:27 UTC (History)
0 users

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+


Attachments
Add missing dependencies for mplayer and mencoder (1.70 KB, patch)
2021-07-05 14:48 UTC, Philipp Ost
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-07-05 14:48:34 UTC
Created attachment 226240 [details]
Add missing dependencies for mplayer and mencoder

`make stage-qa` complains about several missing dependencies for multimedia/mplayer and mulitmedia/mencoder.

The attached patch fixes those.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2021-08-29 13:22:55 UTC
stage-qa is sometimes a bit overly verbose if ports have transitive dependencies. Thank you for reporting, will take a look!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-07 12:22:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=381fe1e14c076068b8a4f14f11db176dc683b668

commit 381fe1e14c076068b8a4f14f11db176dc683b668
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2022-08-07 12:11:20 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-08-07 12:22:08 +0000

    multimedia/{mplayer|mencoder}: Fix stage-qa warnings

    Details:
    - Rework dependencies to fix stage-qa warnings, at least for the default
      packages and a couple configs tested.
    - Add JPEG OPTION to allow to actually disable it (as it is picked up
      automatically in most systems via build dependencies, even if the user
      does not want to include it).

    PR:             256994
    Reported by:    bsd@philippost.de
    MFH:            2022Q3

 multimedia/mencoder/Makefile        |  5 +++--
 multimedia/mplayer/Makefile         |  3 ++-
 multimedia/mplayer/Makefile.optvars | 16 +++++++++++-----
 3 files changed, 16 insertions(+), 8 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-07 14:27:16 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ecd18593d247445a95b024cb4c7f3f9f84cc9e4

commit 3ecd18593d247445a95b024cb4c7f3f9f84cc9e4
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2022-08-07 12:11:20 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-08-07 12:56:16 +0000

    multimedia/{mplayer|mencoder}: Fix stage-qa warnings

    Details:
    - Rework dependencies to fix stage-qa warnings, at least for the default
      packages and a couple configs tested.
    - Add JPEG OPTION to allow to actually disable it (as it is picked up
      automatically in most systems via build dependencies, even if the user
      does not want to include it).

    PR:             256994
    Reported by:    bsd@philippost.de
    MFH:            2022Q3

    (cherry picked from commit 381fe1e14c076068b8a4f14f11db176dc683b668)

 multimedia/mencoder/Makefile        |  5 +++--
 multimedia/mplayer/Makefile         |  3 ++-
 multimedia/mplayer/Makefile.optvars | 16 +++++++++++-----
 3 files changed, 16 insertions(+), 8 deletions(-)