Bug 256995 - textproc/py-pygments: Update to 2.9.0
Summary: textproc/py-pygments: Update to 2.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL: https://github.com/pygments/pygments/...
Keywords:
Depends on: 257471
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-05 15:38 UTC by Thierry Thomas
Modified: 2022-02-19 15:12 UTC (History)
3 users (show)

See Also:
thierry: maintainer-feedback+
thierry: merge-quarterly-
antoine: exp-run+


Attachments
textproc/py-pygments: upgrade to 2.9.0 (1.81 KB, patch)
2021-07-05 15:38 UTC, Thierry Thomas
no flags Details | Diff
textproc/py-pygments: upgrade to 2.9.0 (1.84 KB, patch)
2021-07-25 16:18 UTC, Thierry Thomas
koobs: maintainer-approval+
Details | Diff
update to 2.11.2 (1.53 KB, patch)
2022-01-20 22:25 UTC, Yuri Victorovich
no flags Details | Diff
Upgrade to 2.9.0 (1.50 KB, patch)
2022-02-15 19:01 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2021-07-05 15:38:52 UTC
Created attachment 226241 [details]
textproc/py-pygments: upgrade to 2.9.0

Pygments is lagging, and an upgrade is required to update math/mathicsscript to 3.3.1 (at least to 2.8.0).

The proposed patch upgrades to 2.9.0.

    Release notes at <https://github.com/pygments/pygments/releases/tag/2.9.0>.
    
    - Remove conflict with the defunct paraview.
    
    - Add a test target (3710 passed, 3 skipped).
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2021-07-21 16:28:05 UTC
Maintainer's time-out.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2021-07-21 16:32:16 UTC
After a maintainer's time-out, it seems safer to request an exp-run (this port is a run dependency of 62 ports).
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-25 01:35:22 UTC
@Thierry: py.test may not point where the port needs it to (the python version its  being built for, rather than the default). Recommend:

  ${PYTHON_CMD} -m pytest -v -rs -o addopts=

The last arg ensures deterministic pytest environment by overriding anything set in setup.cfg:[pytest] or other places, which often add unecessary things like additional dev dependencies (like pylint), which we don't need downstream)
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2021-07-25 16:18:08 UTC
Created attachment 226682 [details]
textproc/py-pygments: upgrade to 2.9.0

New patch, with koobs' suggestion for the test target.

Note for Antoine: if you already began the exp-run, no problem, it only affects the test target, no change for the build.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2021-07-26 07:17:26 UTC
maintainer-feedback set to - after maintainer’s time-out, see Comment 1.
Please do not set it back.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-26 08:02:50 UTC
Comment on attachment 226682 [details]
textproc/py-pygments: upgrade to 2.9.0

^Triage: 

Approved by: portmgr (maintainer timeout)
Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2021-08-17 11:30:34 UTC
(In reply to Antoine Brodin from comment #7)

Thanks to a patch from upstream, openage 0.4.1 supports Pygments 2.9.0.

Patch submitted in PR 257471.
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2021-12-25 03:37:50 UTC
Pygments 2.10.0 is available: https://pypi.org/project/Pygments/
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-20 22:25:57 UTC
Created attachment 231195 [details]
update to 2.11.2
Comment 12 Thierry Thomas freebsd_committer freebsd_triage 2022-01-28 09:39:50 UTC
(In reply to Antoine Brodin from comment #11)
I cannot reproduce this failure in my poudrière with Pygments 2.9, it seems that it occurs only with py38-pygments-2.11.2, and the patch committed with openage-0.4.1 was only intended for Pygments 2.9.
Comment 13 Thierry Thomas freebsd_committer freebsd_triage 2022-01-28 17:41:13 UTC
Note: an issue has been raised for game/openage, see https://github.com/SFTtech/openage/issues/1397
Comment 14 Thierry Thomas freebsd_committer freebsd_triage 2022-02-15 18:48:18 UTC
(In reply to Yuri Victorovich from comment #10)
It seems that Pygments-2.11.2 introduced a regression revealed by openage.

Then I suggest that we start by updating textproc/py-pygments to 2.9.0 as proposed with my initial patch: everything is clear with it.

In a second time, we could submit an another PR to upgrade it to the next version.
Comment 15 Yuri Victorovich freebsd_committer freebsd_triage 2022-02-15 18:50:06 UTC
(In reply to Thierry Thomas from comment #14)

I agree.
Comment 16 Thierry Thomas freebsd_committer freebsd_triage 2022-02-15 18:59:17 UTC
(In reply to Yuri Victorovich from comment #15)
OK, thanks.
Then Antoine, could you please launch an exp-run? (it should be the latest one!)
Comment 17 Thierry Thomas freebsd_committer freebsd_triage 2022-02-15 19:01:41 UTC
Created attachment 231844 [details]
Upgrade to 2.9.0

Resubmit the previous patch.
Comment 18 Antoine Brodin freebsd_committer freebsd_triage 2022-02-19 09:24:14 UTC
Exp-run looks fine
Comment 19 Thierry Thomas freebsd_committer freebsd_triage 2022-02-19 15:11:41 UTC
Just committed!
Comment 20 commit-hook freebsd_committer freebsd_triage 2022-02-19 15:12:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=531a8b3c4af4c6009eaa053a4c991ca4fd0020cf

commit 531a8b3c4af4c6009eaa053a4c991ca4fd0020cf
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2021-07-05 15:32:05 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-02-19 15:08:48 +0000

    textproc/py-pygments: upgrade to 2.9.0

    Release notes at <https://github.com/pygments/pygments/releases/tag/2.9.0>.

    - Remove conflict with the defunct paraview.

    - Add a test target (3710 passed, 3 skipped).

    Exp-run by antoine.

    PR:             256995
    Approved by:    maintainer’s time-out

 textproc/py-pygments/Makefile | 13 ++++++-------
 textproc/py-pygments/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 10 deletions(-)