Bug 257047 - databases/mariadb105-client: Fails to build on 11.4/i386 with GCC10+
Summary: databases/mariadb105-client: Fails to build on 11.4/i386 with GCC10+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: i386 Any
: --- Affects Some People
Assignee: Bernard Spil
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-07 21:40 UTC by Raymond Quakkelaar
Modified: 2021-08-29 09:50 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (brnrd)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Quakkelaar 2021-07-07 21:40:40 UTC
As far as I understood, mariadb105 did not compile on i386 with GCC10+.
So it proved true, with several errors in mariadb105-client. 


With changes to makefile mentioned below, I could compile with GCC11 on 11.4.


1. Changed USES (older versions already had noninja and readline):
-USES=bison:build cmake:insource compiler:c++11-lib cpe iconv:translit libedit ncurses shebangfix ssl

+USES=bison:build cmake:insource,noninja readline compiler:c++11-lib cpe iconv:translit libedit ncurses shebangfix ssl


2. Changed the i386 section to this:
.if ${ARCH} == i386
USE_GCC=	yes
CFLAGS+=	-latomic -fasynchronous-unwind-tables
.endif

I have only tested on FreeBSD 11.4 i386 with GCC11, but presume GCC10 (current) should probably work also...
Comment 1 Raymond Quakkelaar 2021-07-08 12:40:55 UTC
BTW: I expect that my changes will probably also work for mariadb104 and mariadb103, since I had the same error messages with those versions before I found the solution for mariadb105.

(Have not tested that afterwards though...)
Comment 2 Bernard Spil freebsd_committer 2021-07-15 19:18:43 UTC
Hi Raymond,

Can you provide git diffs and poudriere testport output?

Cheers, Bernard.
Comment 3 Bernard Spil freebsd_committer 2021-07-15 19:20:23 UTC
(In reply to Raymond Quakkelaar from comment #0)

I've already had comments that the port relies on both libedit and readline.
Is it a necessity? Does it produce an error otherwise?
Comment 4 Raymond Quakkelaar 2021-07-15 19:43:54 UTC
(In reply to Bernard Spil from comment #2)
Hi Bernard,

The irony here is, I tested the mariadb105 build with gcc11 on i386 to be completely up-to-date, not dependend on an eol gcc8, before upgrading to Fbsd 13.0.

However, during this update last weekend, something went horribly wrong, unable to boot, superblocks lost, nothing to repair even with fsck...

Since I had to do a clean install, skipped to 64-bit this time.

To recap, I can no longer (test) build on i386.

I think the noninja probably is mandatory, readline might not be required.
However in my previous bugfix (bug 247535), it only worked with -DUSE_NEW_READLINE_INTERFACE added to CFLAGS. Is this linked to USES readline?

Regards,
Raymond
Comment 5 commit-hook freebsd_committer 2021-08-08 18:50:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aa7bf2b545f6068e84dd0c3dc9e4c85f22a7bc2d

commit aa7bf2b545f6068e84dd0c3dc9e4c85f22a7bc2d
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2021-08-08 11:47:31 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2021-08-08 18:50:01 +0000

    databases/mariadb105-server: Update to 10.5.12

     * Update/fix i386 build [1]

    PR:             257047 [1]
    Reported by:    Raymond Quakkelaar <r quakkelaar quaras nl>
    Security:       38a4a043-e937-11eb-9b84-d4c9ef517024

 databases/mariadb105-server/Makefile                          | 10 ++++------
 databases/mariadb105-server/distinfo                          |  6 +++---
 .../files/patch-storage_mroonga_CMakeLists.txt (gone)         | 11 -----------
 3 files changed, 7 insertions(+), 20 deletions(-)
Comment 6 commit-hook freebsd_committer 2021-08-08 19:58:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d6e883166c711066f5621b106d2615523a2afe7

commit 7d6e883166c711066f5621b106d2615523a2afe7
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2021-08-08 19:55:49 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2021-08-08 19:58:16 +0000

    databases/mariadb104-server: Security update to 10.4.21

    databases/mariadb105-server: Update to 10.5.12

     * Update/fix i386 build [1]

    PR:             257047 [1]
    Reported by:    Raymond Quakkelaar <r quakkelaar quaras nl>
    Security:       38a4a043-e937-11eb-9b84-d4c9ef517024
    MFH:            2021Q3

 databases/mariadb104-server/Makefile               |  8 +++-
 databases/mariadb104-server/distinfo               |  6 +--
 .../files/patch-storage_innobase_lz4.cmake         | 50 +++++++++++++---------
 .../files/patch-storage_innobase_lzo.cmake         | 22 ++--------
 .../files/patch-storage_innobase_snappy.cmake      | 11 ++---
 .../patch-storage_mroonga_CMakeLists.txt (gone)    | 11 -----
 6 files changed, 48 insertions(+), 60 deletions(-)
Comment 7 commit-hook freebsd_committer 2021-08-29 09:48:07 UTC
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2be507323c227e744abd4c608a52a309d7d4a698

commit 2be507323c227e744abd4c608a52a309d7d4a698
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2021-08-08 11:47:31 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2021-08-29 09:47:27 +0000

    databases/mariadb105-server: Update to 10.5.12

     * Update/fix i386 build [1]

    PR:             257047 [1]
    Reported by:    Raymond Quakkelaar <r quakkelaar quaras nl>
    Security:       38a4a043-e937-11eb-9b84-d4c9ef517024

    (cherry picked from commit aa7bf2b545f6068e84dd0c3dc9e4c85f22a7bc2d)

 databases/mariadb105-server/Makefile                          | 10 ++++------
 databases/mariadb105-server/distinfo                          |  6 +++---
 .../files/patch-storage_mroonga_CMakeLists.txt (gone)         | 11 -----------
 3 files changed, 7 insertions(+), 20 deletions(-)
Comment 8 commit-hook freebsd_committer 2021-08-29 09:50:08 UTC
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2101645c469e176278e4d5ab701c091bb05275b3

commit 2101645c469e176278e4d5ab701c091bb05275b3
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2021-08-08 19:55:49 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2021-08-29 09:49:33 +0000

    databases/mariadb104-server: Security update to 10.4.21

    databases/mariadb105-server: Update to 10.5.12

     * Update/fix i386 build [1]

    PR:             257047 [1]
    Reported by:    Raymond Quakkelaar <r quakkelaar quaras nl>
    Security:       38a4a043-e937-11eb-9b84-d4c9ef517024
    MFH:            2021Q3

    (cherry picked from commit 7d6e883166c711066f5621b106d2615523a2afe7)

 databases/mariadb104-server/Makefile               |  8 +++-
 databases/mariadb104-server/distinfo               |  6 +--
 .../files/patch-storage_innobase_lz4.cmake         | 50 +++++++++++++---------
 .../files/patch-storage_innobase_lzo.cmake         | 22 ++--------
 .../files/patch-storage_innobase_snappy.cmake      | 11 ++---
 .../patch-storage_mroonga_CMakeLists.txt (gone)    | 11 -----
 6 files changed, 48 insertions(+), 60 deletions(-)