Bug 257062 - Cleaned trap_fatal's parameter defenition style.
Summary: Cleaned trap_fatal's parameter defenition style.
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL: https://cgit.freebsd.org/src/tree/sys...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-08 18:34 UTC by Vijay Sharma
Modified: 2021-07-17 11:03 UTC (History)
0 users

See Also:


Attachments
Updates to `sys/amd64/amd64/trap.c` (291 bytes, patch)
2021-07-08 18:34 UTC, Vijay Sharma
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vijay Sharma 2021-07-08 18:34:20 UTC
Created attachment 226311 [details]
Updates to `sys/amd64/amd64/trap.c`

I cleaned up the way the parameters of `trap_fatal` are declared in the function's definition. to abide with the C standards. It was bugging me as I was studying the code.
Comment 1 commit-hook freebsd_committer 2021-07-10 11:47:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=55e63ed307fb099722cf6d30a18c9badab9b5d03

commit 55e63ed307fb099722cf6d30a18c9badab9b5d03
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-07-10 10:59:32 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-07-10 11:46:53 +0000

    x86: use ANSI C definition style for trap_fatal

    PR:     257062
    Submitted by:   Vijay Sharma <vijaysh312@gmail.com>
    MFC after:      1 week

 sys/amd64/amd64/trap.c | 4 +---
 sys/i386/i386/trap.c   | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
Comment 2 commit-hook freebsd_committer 2021-07-17 11:03:47 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=fec5a70e1f41235dbbf43482ec2e54df030f4abc

commit fec5a70e1f41235dbbf43482ec2e54df030f4abc
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-07-10 10:59:32 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-07-17 10:52:04 +0000

    x86: use ANSI C definition style for trap_fatal

    PR:     257062

    (cherry picked from commit 55e63ed307fb099722cf6d30a18c9badab9b5d03)

 sys/amd64/amd64/trap.c | 4 +---
 sys/i386/i386/trap.c   | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)