Bug 257102 - x11-toolkits/qt5-declarative: add missing dependency
Summary: x11-toolkits/qt5-declarative: add missing dependency
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-10 21:19 UTC by Philipp Ost
Modified: 2021-07-13 06:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kde)


Attachments
qt5-declarative: add missing dependency (490 bytes, patch)
2021-07-10 21:19 UTC, Philipp Ost
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-07-10 21:19:22 UTC
Created attachment 226360 [details]
qt5-declarative: add missing dependency

stage-qa complains that libQt5QuickTest.so.5.15.2 is linked to libQt5Test.so.5 which is not declared as dependency.

# readelf -d work/stage/usr/local/lib/qt5/libQt5QuickTest.so.5.15.2 | grep Qt5Test
 0x0000000000000001 NEEDED               Shared library: [libQt5Test.so.5]

The attached patch fixes this.
Comment 1 Adriaan de Groot freebsd_committer 2021-07-11 19:09:33 UTC
I'd prefer **not** to have testlib -- a developer-oriented, never-needed-at-runtime Qt component -- installed unless the user actually asks for it **or** there's an application that obviously benefits (e.g. an IDE). That's what current work on **reducing** the dependency burden of Qt and KDE applications is doing.

Is QuickTest used for anything? Linked anywhere? Why is it even installed? Those are questions we can ask ourselves before dialling back the reduction in dependencies.
Comment 2 Philipp Ost 2021-07-11 21:48:56 UTC
Fair enough. I wasn't aware of the efforts to reduce the dependency burden. 

On my system, qt5-testlib gets pulled in by quazip-qt5, which is needed by merkaartor:
$ pkg info -xr qt5-testlib
qt5-testlib-5.15.2_1:
        qt5-declarative-5.15.2_3  <-- I have my patch applied locally
        quazip-qt5-1.1
$ pkg info -xr quazip     
quazip-qt5-1.1:
        merkaartor-0.18.2_30
$
Comment 3 Greg Rivers 2021-07-11 22:54:23 UTC
This missing dependency also breaks wireshark. After upgrading today on a host that does not have kde installed:

# pkg autoremove -y
Deinstallation has been requested for the following 2 packages:

Installed packages to be REMOVED:
        gtk2: 2.24.33
        qt5-testlib: 5.15.2_1

Number of packages to be removed: 2

The operation will free 37 MiB.
[1/2] Deinstalling gtk2-2.24.33...
[1/2] Deleting files for gtk2-2.24.33: 100%
[2/2] Deinstalling qt5-testlib-5.15.2_1...
[2/2] Deleting files for qt5-testlib-5.15.2_1: 100%
pkg: POST-DEINSTALL script failed

# pkg check -d
Checking all packages: 100%
qt5-declarative is missing a required shared library: libQt5Test.so.5
# pkg info -r qt5-declarative
qt5-declarative-5.15.2_3:
        qt5-multimedia-5.15.2_2
# pkg info -r qt5-multimedia
qt5-multimedia-5.15.2_2:
        wireshark-3.4.6
Comment 4 Adriaan de Groot freebsd_committer 2021-07-13 06:43:13 UTC
This is a case of "subpackages would make this *so* easy" and without it's a real pain in the butt. I think this will settle out with QuickTest not being installed (or maybe only as part of a non-default test option) and then hope that there's no actual consumers for it.