Bug 257174 - [NEW PORT] audio/vgmtools: Tools for vgm/vgz files
Summary: [NEW PORT] audio/vgmtools: Tools for vgm/vgz files
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/vgmrips/vgmtools
Depends on:
Reported: 2021-07-14 06:47 UTC by Timothy Beyer
Modified: 2022-08-01 09:19 UTC (History)
3 users (show)

See Also:

audio_vgmtools.shar (2.57 KB, text/plain)
2021-07-14 06:47 UTC, Timothy Beyer
no flags Details
[PATCH] new audio/vgmtools: DISTVERSION, updated so no raw install line (2.76 KB, patch)
2022-08-01 09:19 UTC, Timothy Beyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2021-07-14 06:47:46 UTC
Created attachment 226447 [details]

This provides miscellaneous tools for vgm/vgz/vg7z files, as used by the audio/vgmplay port.  The notable part of this port is that it has the utility vgm_tag, a command line tool to show GD3 tags used in VGM/VGZ/VG7Z files.  It has numerous other very specialized tools which I haven't tried, but may prove useful to others.
Comment 1 Daniel Engberg freebsd_committer 2022-07-17 18:41:07 UTC
Please read "Example 18. Using USE_GITHUB When Upstream Does Not Use Versions" in Porters Handbook

Doesn't upstream include an install section in CMakeLists.txt or why are binaries installed manually? Please also look at https://docs.freebsd.org/en/books/porters-handbook/book/#install-macros
Comment 2 Timothy Beyer 2022-07-20 08:47:13 UTC
(In reply to Daniel Engberg from comment #1)
Hi, thanks for the suggestions.

So far I have made another version that uses DISTVERSION with the g prefix (and I will do that for all non-versioned Github ports going forward as per the Porter's Handbook).

To answer your question about the INSTALL line, in the version from 20210527 that was submitted above, I looked at both CMakeLists and makefile, and both do not contain install commands, so I included a raw INSTALL line.

However, when I updated it to version 20220718 (which surprisingly builds so far with no patches or even changes to pkg-plist), the CMakeLists does now contain an install command, so I will experiment on poudriere with that all in the CMakeLists.txt as the upstream project now does.

Once I confirm with more testing that the newer version is working across amd64 i386 in both 13.1 and 12.3, then I will update the patch here, and will likely remove the INSTALL line, along with some new changes such as the adjustment to the first line not using the $FreeBSD$ tag.
Comment 3 Timothy Beyer 2022-08-01 09:19:30 UTC
Created attachment 235602 [details]
[PATCH] new audio/vgmtools: DISTVERSION, updated so no raw install line

Here's a git format-patch file that updates it to a newer version that has install defined in CMakeLists.txt.  I switched to use DISTVERSION with the g prefix, as specified.

It has been tested in poudriere in various versions (13.1-RELEASE i386, 13.1-RELEASE amd64, 12.3-RELEASE i386, 12.3-RELEASE amd64), and is more compliant with modern ports formatting standards than my previous submission.