Bug 257220 - devel/onetbb: Fails to patch: fetch: commit/fa944e19600500863507ed8e9b1f5a30037d9df6.patch: size mismatch: expected 1467, actual 1465
Summary: devel/onetbb: Fails to patch: fetch: commit/fa944e19600500863507ed8e9b1f5a30...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ganael LAPLANCHE
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-16 17:29 UTC by Matthias Andree
Modified: 2021-07-17 17:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (martymac)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer 2021-07-16 17:29:01 UTC
Try "make -C /usr/ports/devel/onetbb distclean checksum" and see this error shown below. It may make sense to download the patch and commit it to the ports Git... who knows when Github change the output again.

===>   onetbb-2021.3.0 depends on file: /usr/local/sbin/pkg - found
=> oneapi-src-oneTBB-v2021.3.0_GH0.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://codeload.github.com/oneapi-src/oneTBB/tar.gz/v2021.3.0?dummy=/oneapi-src-oneTBB-v2021.3.0_GH0.tar.gz
fetch: https://codeload.github.com/oneapi-src/oneTBB/tar.gz/v2021.3.0?dummy=/oneapi-src-oneTBB-v2021.3.0_GH0.tar.gz: size unknown
fetch: https://codeload.github.com/oneapi-src/oneTBB/tar.gz/v2021.3.0?dummy=/oneapi-src-oneTBB-v2021.3.0_GH0.tar.gz: size of remote file is not known
oneapi-src-oneTBB-v2021.3.0_GH0.tar.gz                1612 kB 5801 kBps    01s
=> fa944e19600500863507ed8e9b1f5a30037d9df6.patch doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://github.com/oneapi-src/oneTBB/commit/fa944e19600500863507ed8e9b1f5a30037d9df6.patch
fetch: https://github.com/oneapi-src/oneTBB/commit/fa944e19600500863507ed8e9b1f5a30037d9df6.patch: size mismatch: expected 1467, actual 1465
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/fa944e19600500863507ed8e9b1f5a30037d9df6.patch
fetch: http://distcache.FreeBSD.org/ports-distfiles/fa944e19600500863507ed8e9b1f5a30037d9df6.patch: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/ports/distfiles/ and try again.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/onetbb
Comment 1 Ganael LAPLANCHE freebsd_committer 2021-07-16 19:55:06 UTC
Hello Matthias, Piotr,

Matthias, thanks a lot for your report.

Piotr, can you check if :

https://github.com/oneapi-src/oneTBB/commit/fa944e19600500863507ed8e9b1f5a30037d9df6.patch

is the patch you expected with commit 1daf680 ? Can you fix distinfo ?

Thanks in advance,

Best regards,

Ganael.
Comment 2 Matthias Andree freebsd_committer 2021-07-16 20:10:30 UTC
I wonder if it's a load balancing issue and sometimes a refetch helps, sometimes not. I *strongly* suggest to add & commit a copy of the small (< 2 kB) patch to avoid formatting differences from the download so we isolate our ports tree from Github matters.
Comment 3 Piotr Kubaj freebsd_committer 2021-07-17 11:03:32 UTC
(In reply to Matthias Andree from comment #2)
Yes, it's this patch.
Comment 4 commit-hook freebsd_committer 2021-07-17 16:59:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=908b8b96c31a9a01af6e39f6863a2f3bb05a7f43

commit 908b8b96c31a9a01af6e39f6863a2f3bb05a7f43
Author:     Ganael LAPLANCHE <martymac@FreeBSD.org>
AuthorDate: 2021-07-17 16:57:26 +0000
Commit:     Ganael LAPLANCHE <martymac@FreeBSD.org>
CommitDate: 2021-07-17 16:57:26 +0000

    devel/onetbb: Integrate patch from previous commit 1daf680

    to avoid fetch problems.

    PR:             257220
    Reported by:    mandree

 devel/onetbb/Makefile                              |  3 ---
 devel/onetbb/distinfo                              |  2 --
 .../files/patch-src_tbbmalloc_frontend.cpp (new)   | 30 ++++++++++++++++++++++
 3 files changed, 30 insertions(+), 5 deletions(-)
Comment 5 Ganael LAPLANCHE freebsd_committer 2021-07-17 17:00:38 UTC
Hello,

I've added the patch to the ports tree.

Thanks again!