Bug 257235 - lang/elixir: Fails to package without SRC option: elixir/lib/module/types/*.ex:No such file or directory
Summary: lang/elixir: Fails to package without SRC option: elixir/lib/module/types/*.e...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-erlang (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-17 14:32 UTC by Miroslav Lachman
Modified: 2022-06-17 20:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (erlang)
koobs: merge-quarterly?


Attachments
failed build log from poudriere (16.19 KB, text/plain)
2021-07-17 14:34 UTC, Miroslav Lachman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2021-07-17 14:32:59 UTC
When option DOCS and SRC are set to OFF then build fails with of.ex and unify.ex "No such file or directory":

---Begin OPTIONS List---
===> The following configuration options are available for elixir-1.11.3:
     DOCS=off: Build and/or install documentation
     SRC=off: Install source code
===> Use 'make config' to modify these settings


=======================<phase: package        >============================
===>  Building package for elixir-1.11.3
pkg-static: Unable to access file /wrkdirs/usr/ports/lang/elixir/work/stage/usr/local/lib/elixir/lib/elixir/lib/module/types/of.ex:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/lang/elixir/work/stage/usr/local/lib/elixir/lib/elixir/lib/module/types/unify.ex:No such file or directory

pkg-plist should be modified if non default options are selected.
Comment 1 Miroslav Lachman 2021-07-17 14:34:30 UTC
Created attachment 226517 [details]
failed build log from poudriere
Comment 2 Dave Cottlehuber freebsd_committer 2022-06-17 19:38:32 UTC
Looking into this, I don't think it makes sense to distribute elixir without
the source code. But we can strip the DOCS still.

I will remove `SRC` as a configurable option from lang/elixir*
Comment 3 commit-hook freebsd_committer 2022-06-17 20:09:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07b93079da18867999e5874fc96afc3b7cf27d15

commit 07b93079da18867999e5874fc96afc3b7cf27d15
Author:     Dave Cottlehuber <dch@FreeBSD.org>
AuthorDate: 2022-06-17 18:46:28 +0000
Commit:     Dave Cottlehuber <dch@FreeBSD.org>
CommitDate: 2022-06-17 20:04:53 +0000

    lang/elixir-devel: remove hard dependency on erlang24

    Since moving from OTP21 as default OTP in lang/erlang, to OTP24,
    we no longer have incompatible bytecode versions between default
    erlang and newer builds. Thus, there is no reason to hard-wire
    the dependency when a simple PATH will work as expected.

    Remove broken SRC as build option.

    PR:             264046
    PR:             257235
    Reported by:    Pat Maddox <pat@patmaddox.com>
    Sponsored by:   SkunkWerks, GmbH

 lang/elixir-devel/Makefile          | 14 +++-----------
 lang/elixir-devel/pkg-message (new) | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 11 deletions(-)
Comment 4 commit-hook freebsd_committer 2022-06-17 20:09:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb00a0446a075c43c0d7eb2d1ac754fda2f09bdd

commit fb00a0446a075c43c0d7eb2d1ac754fda2f09bdd
Author:     Dave Cottlehuber <dch@FreeBSD.org>
AuthorDate: 2022-06-17 19:44:50 +0000
Commit:     Dave Cottlehuber <dch@FreeBSD.org>
CommitDate: 2022-06-17 20:04:54 +0000

    lang/elixir: remove broken SRC build option

    PR:             257235
    Sponsored by:   SkunkWerks, GmbH

 lang/elixir/Makefile          |  7 +++----
 lang/elixir/pkg-message (new) | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 4 deletions(-)