Bug 257243 - net/pload: change of MASTER_SITE URL
Summary: net/pload: change of MASTER_SITE URL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-18 08:10 UTC by J.R. Oldroyd
Modified: 2021-07-21 10:21 UTC (History)
1 user (show)

See Also:
fbsd: maintainer-feedback+


Attachments
patch to update port from 0.9.5_4 to 0.9.5_5 (968 bytes, patch)
2021-07-18 08:10 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Oldroyd 2021-07-18 08:10:54 UTC
Created attachment 226526 [details]
patch to update port from 0.9.5_4 to 0.9.5_5

This patch updates the MASTER_SITE URL.

While here, also fix the original author's name in the pkg-descr file.

Note to committer: I am not sure if MASTER_SITE LOCAL/pav is still current or needed.  If not, please remove it too.
Comment 1 Alexey Dokuchaev freebsd_committer 2021-07-19 02:38:09 UTC
> fix the original author's name in the pkg-descr file.
We typically do not list individual people as authors in port descriptions, esp. if generic WWW is (or can be) provided.

> not sure if MASTER_SITE LOCAL/pav is still current or needed.
Yes, as long as it carries the current distfile (and it does), it can/should be kept.
Comment 2 J.R. Oldroyd 2021-07-19 09:59:40 UTC
(In reply to Alexey Dokuchaev from comment #1)

> We typically do not list individual people as authors in port descriptions, esp. if generic WWW is (or can be) provided.

Okay, please undo the change to the pkg-descr file then.

It seems that the original author did use the name "Matt" according to his own man page.  That name has been in the pkg-descr file for years/decades.

I added the (now-broken) URL of his original web site, and I added a link to my own page about it: you can keep or remove them as you feel fit.  

> Yes, as long as it carries the current distfile (and it does), it can/should be kept.

Okay.  I see it is downloading from LOCAL/pav now.  It didn't seem to work when I tried the other day.
Comment 3 commit-hook freebsd_committer 2021-07-21 10:21:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0b8a1dd17f569159059c244b796238c6f2d2de94

commit 0b8a1dd17f569159059c244b796238c6f2d2de94
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-07-21 10:19:52 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-07-21 10:19:59 +0000

    net/pload: the port had been slightly improved (+)

    - Update MASTER_SITES (chase HTTP 302 redirection)
    - Remove author attribution from the port description
      (it was also not quite accurate) and point WWW line
      to a working site instead

    PR:             257243
    Submitted by:   maintainer

 net/pload/Makefile  | 3 +--
 net/pload/pkg-descr | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)