Bug 257365 - devel/py-click-threading: Update to 0.5.0 (Fixes Python 3.8 support)
Summary: devel/py-click-threading: Update to 0.5.0 (Fixes Python 3.8 support)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Justin Hibbits
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2021-07-23 20:13 UTC by Justin Hibbits
Modified: 2021-08-07 03:06 UTC (History)
4 users (show)

See Also:
geier: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Update devel/py-click-threading to 0.5.0 (1.61 KB, patch)
2021-08-01 15:17 UTC, Li-Wen Hsu
lwhsu: maintainer-approval? (geier)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer 2021-07-23 20:13:10 UTC
devel/py-click-threading needs updated to support python3.8, particularly this change to click_threading/monkey.py is needed:

https://github.com/click-contrib/click-threading/commit/99c47e64c7897f5a422e07d0112b42f0a06ac255#diff-e1963f3aa944d564694dd1ef3ef7ecbccde62c526347466e301ae43461bc0f20

Found when trying to run deskutils/py-vdirsyncer with python 3.8
Comment 1 Li-Wen Hsu freebsd_committer 2021-08-01 15:17:54 UTC
Created attachment 226845 [details]
Update devel/py-click-threading to 0.5.0
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-02 04:30:52 UTC
deskutils/py-vdirsyncer (consumer) should be checked for current (proposed) version compatibility. RUN_DEPENDS specifies >=, but upstream may specify a < pinned version, or not be compatible with 0.5.0 (or some other issue).

Also, if the current version of the port doesn't support 3.8, an initial change to cap the current version to -3.7 should be committed, so that can be merged first and separately

Also noted, the click RUN_DEPENDS should also match the version specifier declared in upstream sources ('click>=5.0',), and upstream isnt testing against Python 3.10, but this ports USES=python <version-spec> allows it. We should either confirm 3.10 passes tests, or cap it at -3.9

^Triage: Reporter is committer, assign accordingly.

@Justin, Happy to review/approve this for you if you don't have a ports bit. Holler if you need help or have questions