Bug 257396 - math/py-numpy typo in ATLAS option forces use of lapack instead of alapack
Summary: math/py-numpy typo in ATLAS option forces use of lapack instead of alapack
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-24 20:34 UTC by alt2600
Modified: 2021-07-25 00:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (python)


Attachments
patch-Makefile-fixtypo-alapack (574 bytes, patch)
2021-07-24 20:34 UTC, alt2600
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2021-07-24 20:34:36 UTC
Created attachment 226659 [details]
patch-Makefile-fixtypo-alapack

Not sure if this is intended or not but if the ATLAS option is taken the lapack lib in the ATLAS_VARS as the string defines to use alpack for lapack library, but it should be alapack, see output of configure. I only ask and post as I have used the framework of this numpy port to get scipy building with other blas libraries using the same mechanisms to dynamically set site.cfg, and it seems to work, but I noticed it was not using the Atlas libalapack libraries but instead saying it is using atlas wihtout atlas lapack and defaulting back to normal lapack. Just want to make sure this is a typo and intent is to use the atlas lapack version for the ATLAS option. see below and attached patch. I just want to make sure I prepare the best version for the scipy patch I am preparing by checking this first. in both cases numpy builds with no orphans.


###Unpatched Uses lapack

creating /tmp/tmplnipbtve/tmp
creating /tmp/tmplnipbtve/tmp/tmplnipbtve
compile options: '-MMD -MF /tmp/tmplnipbtve/file.c.d -c'
cc: /tmp/tmplnipbtve/file.c
  FOUND:
    libraries = ['lapack', 'lapack']
    library_dirs = ['/usr/local/lib']
    language = f77

  FOUND:
    include_dirs = ['/usr/local/include']
    language = f77
    libraries = ['ptf77blas', 'ptcblas', 'lapack', 'lapack']
    library_dirs = ['/usr/local/lib']
    define_macros = [('ATLAS_WITHOUT_LAPACK', None)]

/usr/local/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'define_macros'
  warnings.warn(msg)
running config


###With Patch use Atlas's lapack

creating /tmp/tmpebgjdj2s/tmp
creating /tmp/tmpebgjdj2s/tmp/tmpebgjdj2s
compile options: '-MMD -MF /tmp/tmpebgjdj2s/file.c.d -c'
cc: /tmp/tmpebgjdj2s/file.c
  libraries tatlas not found in ['/usr/lib', '/usr/local/lib', '/usr/local/lib/gcc10/gcc/x86_64-portbld-freebsd12.2/10.3.0/../../../']
Library tatlas was not found. Ignoring
  FOUND:
    include_dirs = ['/usr/local/include']
    language = f77
    libraries = ['alapack', 'ptf77blas', 'ptcblas']
    library_dirs = ['/usr/local/lib']
    define_macros = [('ATLAS_INFO', '"None"')]

  FOUND:
    include_dirs = ['/usr/local/include']
    language = f77
    libraries = ['alapack', 'ptf77blas', 'ptcblas']
    library_dirs = ['/usr/local/lib']
    define_macros = [('ATLAS_INFO', '"None"')]

/usr/local/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'define_macros'
  warnings.warn(msg)
running config
Comment 1 commit-hook freebsd_committer 2021-07-25 00:21:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=683962036c550ca52273730416ba42e6e97eb7ce

commit 683962036c550ca52273730416ba42e6e97eb7ce
Author:     alt2600@icloud.com <alt2600@icloud.com>
AuthorDate: 2021-07-24 23:59:17 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2021-07-24 23:59:17 +0000

    math/py-numpy: Fix typo

    - Bump PORTREVISION for package change

    PR:             257396

 math/py-numpy/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer 2021-07-25 00:22:07 UTC
Committed. Thanks!