Bug 257430 - textproc/libdiff: Does not fully respect LOCALBASE
Summary: textproc/libdiff: Does not fully respect LOCALBASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-26 08:54 UTC by John Marshall
Modified: 2021-08-03 16:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)


Attachments
Patch port Makefile to pass PREFIX to configure script (322 bytes, patch)
2021-07-26 08:54 UTC, John Marshall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2021-07-26 08:54:27 UTC
Created attachment 226708 [details]
Patch port Makefile to pass PREFIX to configure script

The lbidiff configure script sets PREFIX="/usr/local" which forces some of the files to be staged to ${STAGEDIR}/usr/local instead of ${STAGEDIR}${LOCALBASE}, resulting in the port install target not finding those files.

The attached patch adds CONFIGURE_ARGS+= PREFIX=${PREFIX} to the port's Makefile to force the desired ${STAGEDIR}${LOCALBASE} destination for all of the port's files.

Maybe this is not the canonical way to fix this (do we need to 'patch' the configure script instead?) but "it works for me" and it's a simple solution.
Comment 1 commit-hook freebsd_committer 2021-08-03 16:45:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6987fb41bc0293fd594d0c55e74232e3c8069f64

commit 6987fb41bc0293fd594d0c55e74232e3c8069f64
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2021-08-03 16:42:28 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2021-08-03 16:45:01 +0000

    textproc/libdiff: respect PREFIX

    PR:             257430
    Submitted by:   John Marshall <john@jmarshall.id.au>

 textproc/libdiff/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Baptiste Daroussin freebsd_committer 2021-08-03 16:46:09 UTC
this is the right way to fix thank you